Commit graph

10 commits

Author SHA1 Message Date
Tiago Botelho
7385e7cd47
Backports changes made to One notification per code review
The EE merge request can be found here:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8442
2018-12-07 14:24:37 +00:00
Yorick Peterse
2039c8280d
Disable existing offenses for the CodeReuse cops
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
gfyoung
dfbe5ce435 Enable frozen string literals for app/workers/*.rb 2018-06-27 07:23:28 +00:00
Mario de la Ossa
02741ca4c5
Backport 5480-epic-notifications from EE 2018-05-07 12:58:47 -06:00
Jan Provaznik
c194636470 Better group support notes-related code
Updates notes-related services and rendering so this code can be
easily used for group-scoped resources (specifically Epics).

Related to gitlab-ee!5205
2018-04-05 13:29:57 +02:00
Douwe Maan
0b15570e49 Add ApplicationWorker and make every worker include it 2017-12-05 11:59:39 +01:00
Stan Hu
99432cbcfb Preserve optional second parameter in NewNoteWorker jobs
If there are any old or retries in the Sidekiq queue, NewNoteWorker
will fail with the error:

wrong number of arguments (given 2, expected 1)

This change allows the optional second argument to be used
to preserve backwards compatibility. It can be removed later.

Closes #24678
2016-11-19 10:18:44 -08:00
Oswaldo Ferreira
d48d879ef5 Does not raise error when Note not found when processing NewNoteWorker
- Also remove unnecessary param
2016-11-11 22:54:11 -02:00
Yorick Peterse
97731760d7
Re-organize queues to use for Sidekiq
Dumping too many jobs in the same queue (e.g. the "default" queue) is a
dangerous setup. Jobs that take a long time to process can effectively
block any other work from being performed given there are enough of
these jobs.

Furthermore it becomes harder to monitor the jobs as a single queue
could contain jobs for different workers. In such a setup the only
reliable way of getting counts per job is to iterate over all jobs in a
queue, which is a rather time consuming process.

By using separate queues for various workers we have better control over
throughput, we can add weight to queues, and we can monitor queues
better. Some workers still use the same queue whenever their work is
related. For example, the various CI pipeline workers use the same
"pipeline" queue.

This commit includes a Rails migration that moves Sidekiq jobs from the
old queues to the new ones. This migration also takes care of doing the
inverse if ever needed. This does require downtime as otherwise new jobs
could be scheduled in the old queues after this migration completes.

This commit also includes an RSpec test that blacklists the use of the
"default" queue and ensures cron workers use the "cronjob" queue.

Fixes gitlab-org/gitlab-ce#23370
2016-10-21 18:17:07 +02:00
Josh Frye
f9218898ec [WIP] Background process note logic for #3948 2016-01-28 13:04:42 -05:00