Commit Graph

11 Commits

Author SHA1 Message Date
GitLab Bot 24fe7aa2aa Add latest changes from gitlab-org/gitlab@master 2019-10-22 18:06:35 +00:00
GitLab Bot 5e5da0f1ee Add latest changes from gitlab-org/gitlab@master 2019-10-04 18:05:55 +00:00
GitLab Bot 0d46bf0638 Add latest changes from gitlab-org/gitlab@master 2019-10-04 12:06:14 +00:00
GitLab Bot 20450649ca Add latest changes from gitlab-org/gitlab@master 2019-09-27 09:06:26 +00:00
GitLab Bot b082790134 Add latest changes from gitlab-org/gitlab@master 2019-09-18 18:06:14 +00:00
GitLab Bot 80f61b4035 Add latest changes from gitlab-org/gitlab@master 2019-09-18 14:02:45 +00:00
Mayra Cabrera 6d0238a38c Updates the merge request author responsibility
Indicate it's the author's responsibility to prepare the merge request
for a database review
2019-09-04 03:09:05 +00:00
Mayra Cabrera 9d5ea4203c Migrations guide: use atomic steps, when possible
Currently, the DB migrations guide says that "you must" use non-blocking
operations (such as CREATE INDEX CONCURRENTLY), always.

But this does not make sense in cases of empty tables and leads to
splitting the work to multiple non-atomic
(with disable_ddl_transaction!) DB migrations.

To follow KISS principle, to have fewer DB migrations steps,
to have them atomic when it's possible and simplify deployment
and troubleshooting, the following exceptions were added
to the doc:

- index creation,
- index dropping,
- defining an FK,
- adding a column with DEFAULT,
2019-08-27 10:22:12 +00:00
Mayra Cabrera e61d37171e Adds DB guidelines regarding execution timing
- Add a new guideline regarding the file location of background
migrations
- Add a new section about execution timing guidelines for all different
kinds of migrations
2019-08-09 06:47:03 +00:00
Andreas Brandl 412a0a6722
Add points how to prepare for database reviews
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65126.

Came up in the database office hours call on 2019-07-25.
2019-07-25 19:35:50 +02:00
Toon Claes 34a5f77e77 Document database review process
See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
2019-07-19 17:33:48 +00:00