Commit graph

5 commits

Author SHA1 Message Date
Sean McGivern
5883ce95ef current_application_settings belongs on Gitlab::CurrentSettings
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
Toon Claes
7188b4d839 Make the revision on the /help page clickable
For quicker access, add hyperlink to the gitlab.com commits page for the current
REVISION of GitLab.
2017-06-09 10:35:42 +02:00
Robert Speicher
45824aabc6 Allow non-admin users to see version information
We want users to know what features they have available (and to pressure
their admins to upgrade).
2015-09-23 17:18:15 -04:00
Robert Speicher
be142e6bd6 Move the version_check_enabled check from view to helper 2015-09-23 16:28:51 -04:00
Robert Speicher
48cfad9013 Add a view spec (gasp!) for help/index 2015-09-23 16:20:58 -04:00