gitlab-org--gitlab-foss

Commit Graph

Author	SHA1	Message	Date
Stan Hu	39f252254b	Make sure there's only one slash as path separator In Ruby 2.4, `URI.join("http://test//", "a").to_s` will remove the double slash, however it's not the case in Ruby 2.5. Using chomp should work better for the intention, as we're not trying to allow things like ../ or / paths resolution. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53180	2018-11-09 15:36:45 -08:00
Stan Hu	8b4154b57f	Enable frozen strings in lib/banzai/filter/.rb Excludes a few filters that require more work: lib/banzai/filter/image_lazy_load_filter_spec.rb * lib/banzai/filter/syntax_highlight_filter_spec.rb * lib/banzai/filter/table_of_contents_filter_spec.rb Part of #47424	2018-07-23 02:39:45 -07:00
Francisco Javier López	bf0331dc72	Resolve "DashboardController#activity.json is slow due to SQL"	2017-11-06 16:52:56 +00:00

Author

SHA1

Message

Date

Stan Hu

39f252254b

Make sure there's only one slash as path separator

In Ruby 2.4, `URI.join("http://test//", "a").to_s` will
remove the double slash, however it's not the case in
Ruby 2.5. Using chomp should work better for the intention,
as we're not trying to allow things like ../ or / paths
resolution.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53180

2018-11-09 15:36:45 -08:00

Stan Hu

8b4154b57f

Enable frozen strings in lib/banzai/filter/*.rb

Excludes a few filters that require more work:

* lib/banzai/filter/image_lazy_load_filter_spec.rb
* lib/banzai/filter/syntax_highlight_filter_spec.rb
* lib/banzai/filter/table_of_contents_filter_spec.rb

Part of #47424

2018-07-23 02:39:45 -07:00

Francisco Javier López

bf0331dc72

Resolve "DashboardController#activity.json is slow due to SQL"

2017-11-06 16:52:56 +00:00

3 Commits