Commit Graph

8 Commits

Author SHA1 Message Date
Lukas Eipert 253e1818aa
Create helper to get all changed files
Danger apparently has three different objects which could contain files
you often want to check:

 - git.added_files
 - git.modified_files
 - git.renamed_files

The problem: If a file is renamed, `modified_files` contains the file
path before the rename. In some Danger checks we use `added_files` +
`modified_files`, which might contain the deleted paths of renamed
files, but missing the new paths of renamed files.

So we need to consider `renamed_files` as well.
2018-10-22 11:04:55 +02:00
Thong Kuah 8f4745deb4 Fix regexp for detected `db/schema.rb` and `ee/db/geo/schema.rb` 2018-07-26 10:31:45 +12:00
Robert Speicher 27843cd2e7
Autocorrect RuboCop violations in danger/**/Dangerfile 2018-07-11 14:44:35 -05:00
Rémy Coutable 545c961dbc
Wrap DB paths in backticks in the Danger check
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 19:12:44 +02:00
Yorick Peterse b851fe8635
Fix "Database Team" typo for Danger 2018-07-11 14:51:48 +02:00
Yorick Peterse ced15dd531
Tweak the Danger settings for DB changes
Instead of only checking for migrations, we now check for a variety of
files and directories that require a database review. We also include
some steps on how to make sure changes are reviewed.
2018-07-11 14:48:31 +02:00
Rémy Coutable ab87e7bab1
Improve Danger files after first review
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 11:52:03 +02:00
Rémy Coutable 5679837cd4
Start to use Danger for automating MR reviews
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 11:52:01 +02:00