Commit Graph

6 Commits

Author SHA1 Message Date
Jan Provaznik 0fc9f9d3e7 Add version 4.2 to all existing migrations
DB schema generated by a migration may look different in
rails 4 and 5 (because rails 5 may use different default values).
For this reason it's important to explicitly set for which rails
version a migration was written for.

See https://stackoverflow.com/questions/35929869/activerecordmigration-deprecation-warning-asks-for-rails-version-but-im-no/35930912#35930912
2018-11-22 13:18:28 +01:00
Sean McGivern d8be981466 Prevent update_column_in_batches on large tables
add_column_with_default is implemented in terms of update_column_in_batches, but
update_column_in_batches can be used independently. Neither of these should be
used on the specified large tables, because they will cause issues on large
instances like GitLab.com.

This also ignores the cop for all existing migrations, renaming
AddColumnWithDefaultToLargeTable where appropriate.
2017-11-17 16:56:50 +00:00
Grzegorz Bizon 3fd4a37d58 Disable transactions in migrations that should not use it 2017-06-21 14:35:06 +02:00
Rémy Coutable b8b9ed55df Disable Migration/UpdateColumnInBatches for old migrations
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-29 11:28:23 +02:00
Yorick Peterse b7c5cf9edb
Don't drop in DropAndReaddHasExternalWikiInProjects
Dropping a column and then re-adding it can lead to the application
throwing errors as the column may temporarily not exist. To work around
this we'll reset the various project rows in batches _without_ removing
any columns.
2016-07-21 17:43:43 +02:00
Rémy Coutable 3845f12de8
Fix migration to make it fast
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-21 12:45:03 +02:00