b7dfe2ae40
Add latest changes from gitlab-org/gitlab@master
2019-09-13 13:26:31 +00:00
1ce5bcacdb
Remove code related to object hierarchy in MySQL
...
These are not required because MySQL is not
supported anymore
2019-07-25 15:35:06 +08:00
eb88ca7646
Rename methods that conflict in Rails 5.2
...
Adds suffix to enum methods and changes `in_groups` to
`of_groups`
2019-05-12 23:42:06 -05:00
c653921b6f
Add subresources removal to member destroy service
2019-01-31 16:52:50 +01:00
1653f7b1c6
Delete confidential issue todos for guests
...
Fix leaking information of confidential issues on TODOs
when user is downgraded to guest access.
2018-12-14 10:38:52 -02:00
501fb04ec6
Delete todos when users loses target read permissions
2018-07-30 13:29:18 +02:00
fbde835404
Enable more frozen string in app/services/**/*.rb
...
Partially addresses #47424 .
2018-07-17 15:19:40 -07:00
74a24a4fab
Don't delete todos or unassign issues and MRs when a user leaves a project
2018-03-07 17:18:01 -06:00
1c88d92b3f
Improve Member services
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-02-27 16:02:22 +01:00
bf41063679
Remove explicit audit event log in MembershipActions
...
Move it to Members::ApproveAccessRequestService.
Also, note that there was a double audit event log for access request
destruction.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-02-27 16:02:22 +01:00
2cf3fc18a6
Refactor member view by using presenter
...
- Create MemberPresenter alongside with GroupMemberPresenter and ProjectMemberPresenter
- Make Member model Presentable
- Move action_member_permission from MembersHelper into the MemberPresenter
- Added rspec using double, separate specs for GroupMemberPresenter and ProjectMemberPresenter
Fixes #28004 .
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-12-11 18:30:56 +01:00
260c8da060
Whitelist or fix additional `Gitlab/PublicSend` cop violations
...
An upcoming update to rubocop-gitlab-security added additional
violations.
2017-08-14 12:14:11 -04:00
b7d8df503c
Enable Style/MutableConstant
2017-02-23 09:31:56 -06:00
e9d7b4f765
Invert method's naming
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
c8b1311934
Fix a few things after the initial improvment to Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
3158f57dba
Improve Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
8b1656282b
Merge branch 'master' into expiration-date-on-memberships
2016-08-18 15:54:07 +01:00
29850364ec
New AccessRequests API endpoints for Group & Project
...
Also, mutualize AccessRequests and Members endpoints for Group &
Project.
New API documentation for the AccessRequests endpoints.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-08-10 19:07:05 +02:00
b4b51441aa
Extract Members::AuthorizedDestroyService from Members::DestroyService.
2016-08-04 23:34:57 +02:00
654565c9dc
Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member
...
This is a try for a new approach to put the access checks at the service level.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 06:06:34 +02:00
a08a26ac81
Don't send the "access declined" email on access request withdrawal
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
4652489f40
New Members::DestroyService
...
This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
GitLab Bot