GitLab Bot
be4b3134a2
Add latest changes from gitlab-org/gitlab@master
2021-05-04 15:10:36 +00:00
GitLab Bot
2516f0d87b
Add latest changes from gitlab-org/gitlab@master
2021-01-29 18:09:17 +00:00
GitLab Bot
2a65a97e12
Add latest changes from gitlab-org/gitlab@master
2019-12-18 00:08:09 +00:00
GitLab Bot
80f61b4035
Add latest changes from gitlab-org/gitlab@master
2019-09-18 14:02:45 +00:00
Rémy Coutable
6b39f55d3f
Add cache to the 'compile-assets' and 'gitlab:assets:compile' jobs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-02-05 14:04:54 +01:00
Jacopo
d2851f41ba
Extend override check to also check arity
...
Override now cares about parents method arity: if parents arity
doesn't match raises an error.
2018-12-22 14:10:43 +01:00
gfyoung
f93f8f569d
Enable even more frozen string for lib/gitlab
...
Enables frozen string for the following:
* lib/gitlab/patch/**/*.rb
* lib/gitlab/popen/**/*.rb
* lib/gitlab/profiler/**/*.rb
* lib/gitlab/project_authorizations/**/*.rb
* lib/gitlab/prometheus/**/*.rb
* lib/gitlab/query_limiting/**/*.rb
* lib/gitlab/quick_actions/**/*.rb
* lib/gitlab/redis/**/*.rb
* lib/gitlab/request_profiler/**/*.rb
* lib/gitlab/search/**/*.rb
* lib/gitlab/sherlock/**/*.rb
* lib/gitlab/sidekiq_middleware/**/*.rb
* lib/gitlab/slash_commands/**/*.rb
* lib/gitlab/sql/**/*.rb
* lib/gitlab/template/**/*.rb
* lib/gitlab/testing/**/*.rb
* lib/gitlab/utils/**/*.rb
* lib/gitlab/webpack/**/*.rb
Partially addresses gitlab-org/gitlab-ce#47424 .
2018-11-19 18:24:22 -08:00
Lin Jen-Shin
e8a455dc92
Following the feedbacks
2018-09-11 18:45:49 +08:00
Lin Jen-Shin
517ee9fd04
Fix Override. Properly define prepended
...
We should never be sloppy!
2018-09-11 18:45:49 +08:00
Lin Jen-Shin
f71fc9328c
Also verify if extending would override a class method
...
Since extending a class means including on the singleton class of the
class, this should now complain this:
``` ruby
module M
extend Gitlab::Utils::Override
override :f
def f
super.succ
end
end
class C
extend M
def self.f
0
end
end
```
It should complain because `C.f` wasn't calling `M#f`.
This should pass verification:
``` ruby
module M
extend Gitlab::Utils::Override
override :f
def f
super.succ
end
end
class B
def self.f
0
end
end
class C < B
extend M
end
```
Because `C.f` would now call `M#f`, and `M#f` does override something.
2018-06-05 13:40:52 +08:00
Lin Jen-Shin
8139895b43
Use Gitlab::Utils::Override over defined?(super)
2017-12-26 17:18:10 +08:00
