Commit graph

13 commits

Author SHA1 Message Date
gfyoung
be42c05054 Enable more frozen string in app/controllers/
Enables frozen string for the following:

* app/controllers/dashboard/**/*.rb
* app/controllers/explore/**/*.rb
* app/controllers/google_api/**/*.rb
* app/controllers/groups/**/*.rb
* app/controllers/import/**/*.rb
* app/controllers/instance_statistics/**/*.rb
* app/controllers/ldap/**/*.rb
* app/controllers/oauth/**/*.rb
* app/controllers/profiles/**/*.rb

Partially addresses #47424.
2018-09-23 12:48:02 -07:00
Lin Jen-Shin
4ee08b77bc Updates from rubocop -a 2018-07-09 21:13:08 +08:00
James Lopez
67d06dee30 refactor users update service 2017-09-28 08:46:39 +02:00
James Lopez
9621dd0c9d refactor services to match EE signature 2017-09-28 08:46:39 +02:00
James Lopez
b804db2648 refactor update user service not to do auth checks 2017-06-23 11:41:43 +02:00
James Lopez
0ee002c70e more refactoring 2017-06-23 11:41:42 +02:00
James Lopez
c9fd3dc42c more refactoring based on feedback 2017-06-23 11:41:42 +02:00
James Lopez
158550cf37 added service in the rest of controllers and classes 2017-06-23 11:41:42 +02:00
blackst0ne
a544e46bb0 Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers 2017-06-07 09:45:16 +11:00
Yorick Peterse
5371da341e
Remove event caching code
Flushing the events cache worked by updating a recent number of rows in
the "events" table. This has the result that on PostgreSQL a lot of dead
tuples are produced on a regular basis. This in turn means that
PostgreSQL will spend considerable amounts of time vacuuming this table.
This in turn can lead to an increase of database load.

For GitLab.com we measured the impact of not using events caching and
found no measurable increase in response timings. Meanwhile not flushing
the events cache lead to the "events" table having no more dead tuples
as now rows are only inserted into this table.

As a result of this we are hereby removing events caching as it does not
appear to help and only increases database load.

For more information see the following comment:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6578#note_18864037
2016-11-23 14:17:07 +01:00
Douwe Maan
26ad250989 Add a page title to every page. 2015-04-30 19:12:15 +02:00
Drew Blessing
c26d392b1a Expire event cache on avatar creation/removal 2013-12-11 09:30:22 -06:00
Drew Blessing
b08608b261 Issue 5716 - Allow removal of avatar
Add class and style

Add spinach tests

Add entry to CHANGELOG

Add entry to CHANGELOG
2013-12-02 16:20:34 -06:00