Commit graph

23 commits

Author SHA1 Message Date
Robert Speicher
fec9fb05a5 Merge branch 'security-10-4-todo-api-reveals-sensitive-information' into 'security-10-4'
Restrict Todo API mark_as_done endpoint to the user's todos only
2018-02-09 12:16:25 -06:00
blackst0ne
27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Jacopo
2f40dac352 Refactor have_http_status into have_gitlab_http_status in the specs 2017-10-20 10:13:18 +02:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Robert Speicher
9513bd18c4 Ensure all project factories use :repository trait or :empty_project 2017-08-01 14:51:52 -04:00
Rémy Coutable
05e152fa7f
Fix the :project factory by not copying the test repo twice
Also, fixing some calls to the :project factory with the :test_repo
trait since this trait is already included in the :project factory.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 09:58:06 +02:00
Jacopo
ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Timothy Andrew
9ccd8b8755
Migrate the Todos API to use issuable_iid
- Instead of `issuable_id`
2017-03-07 13:55:59 +05:30
Sean McGivern
11dd2348c4 Merge branch '22951-fix-todos-api-endpoint-error-for-commits' into 'master'
Fix todos API endpoint application error

Closes #22951

See merge request !9351
2017-03-01 09:59:15 +00:00
George Andrinopoulos
85c87be361 Add spec for todo with target_type Commit 2017-02-21 15:45:10 +02:00
Robert Schilling
1ef911f0e0 API: Use POST requests to mark todos as done 2017-02-21 12:01:15 +01:00
Robert Schilling
c70dfbc686 Add a custom pagination matcher 2017-02-16 15:38:40 +01:00
Robert Speicher
3a5df1d8fc Merge branch 'fix-api-mr-permissions' into 'security'
Ensure that only privileged users can access merge requests in the API

See merge request !2053
2017-01-23 13:54:35 -05:00
Rémy Coutable
9c560b5cdf
Replace many :project with :empty_projects in API specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-17 11:41:27 -05:00
Paco Guzman
1f2253545b Use cache for todos counter calling TodoService 2016-08-12 17:40:03 +02:00
Robert Schilling
baa9ce8480 Return the number of marked todos 2016-07-19 13:09:57 +02:00
Robert Schilling
87ac9c9850 Support creating a todo on issuables via API 2016-07-01 14:52:04 +02:00
Robert Schilling
3942621329 Expose target, filter by state as string 2016-07-01 14:52:04 +02:00
Robert Schilling
631765748e Expose action_name 2016-07-01 10:49:34 +02:00
Robert Schilling
69397d559f Assert response body 2016-07-01 10:49:34 +02:00
Robert Schilling
f3abd18c9c Add user to project to see todos 2016-07-01 10:49:34 +02:00
Robert Schilling
b94088d512 Make tests follow the guidelines 2016-07-01 10:49:34 +02:00
Douglas Barbosa Alexandre
a1f224d3f7 Add Todos API 2016-07-01 10:49:34 +02:00