Commit graph

20 commits

Author SHA1 Message Date
Jacopo
181cd299f9 Adds Rubocop rule for line break after guard clause
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
2017-11-16 17:58:29 +01:00
Toon Claes
b40ff63412 Fix SAML error 500 when no groups are defined for user
When there are no groups defined in the auth hash attributes,
`Gitlab::Saml::AuthHash#groups` should return an empty array, and
`Gitlab::Saml::User#find_user` should not mark the user as external.

Closes gitlab-org/gitlab-ce#38923.
2017-10-18 10:17:14 +02:00
Tiago Botelho
011c168bff Refactors SAML identity creation in gl_user. 2017-10-02 11:35:09 +01:00
Tiago Botelho
718e5b0865 Attempt to link saml users to ldap by email 2017-09-25 09:44:31 +01:00
Alexander Keramidas
4df54f2607 Profile updates from providers 2017-09-06 16:38:52 +03:00
Douwe Maan
5c7f9d69e3 Fix code for cops 2017-02-23 09:31:57 -06:00
Douwe Maan
8a4d68c53e Enable Style/ConditionalAssignment 2017-02-23 09:31:57 -06:00
Grzegorz Bizon
9e211091a8 Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
Patricio Cano
c593154cb4 Moved find_or_create_ldap_user method to parent class and added logging. 2016-06-07 11:21:20 -05:00
Patricio Cano
7038440e34 Adjust the SAML control flow to allow LDAP identities to be added to an existing SAML user. 2016-06-06 18:47:49 -05:00
Patricio Cano
05a611a091 Better control flow and added guard clause. 2016-04-11 17:25:18 -05:00
Patricio Cano
1d2429af9b Add missing proper nil and error handling to SAML login process. 2016-04-07 16:45:33 -05:00
Patricio Cano
8110e75309 Implemented suggested fixes 2016-04-06 18:12:25 -05:00
Patricio Cano
eb0f1de36c Added CHANGELOG item 2016-04-06 16:21:58 -05:00
Patricio Cano
3a36fa8957 Fix error that was causing only one group to be returned and corrected specs to use the proper attribute type 2016-04-06 16:03:35 -05:00
Patricio Cano
518ec6b266 Changed config syntax and improved how chaanges in group memberships are handled when external groups is set up 2016-04-05 19:20:18 -05:00
Patricio Cano
1a168279fa Prepare SAML for group retrieval 2016-04-04 19:09:12 -05:00
Patricio Cano
06376be56a Decouple SAML authentication from the default Omniauth logic 2016-02-18 17:01:07 -05:00
Douwe Maan
873b0db220 Revert "Merge branch 'saml-decoupling' into 'master' "
This reverts commit c04e22fba8, reversing
changes made to 0feab326d5.
2016-02-18 22:14:53 +01:00
Patricio Cano
f014127e17 Decouple SAML authentication from the default Omniauth logic 2016-02-18 13:22:19 -05:00