kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
41784 commits 1 branch 0 tags 899 MiB
Commit graph

18 commits

Author SHA1 Message Date
Sam Rose
d6d22a5dbd Enable ColorVariable in scss-lint 2016-12-01 20:22:51 -05:00
Clement Ho
d698ec0ebd Enable PseudoElement in scss-lint 2016-10-26 12:06:07 -05:00
Annabel Dunstone Gray
3b93574a35 Merge branch 'enable-scss-lint-single-line-per-selector' into 'master' 
Enable SingleLinePerSelector in scss-lint

## What does this MR do?
Enables `SingleLinePerSelector` in `.scss-lint.yml`

## Are there points in the code the reviewer needs to double check?
This MR touches a lot of files, just need another pair of eyes to look through and make sure I didn't break anything.

## Why was this MR needed?
Improve SCSS maintainability and consistency

## Screenshots (if relevant)
None

## Does this MR meet the acceptance criteria?

- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
#23485

See merge request !7081
 2016-10-25 13:52:26 +00:00
Annabel Dunstone Gray
add3a2c443 Merge branch 'enable-scss-lint-space-after-variable-colon' into 'master' 
Enable SpaceAfterVariableColon in scss-lint

## What does this MR do?
Enables `SpaceAfterVariableColon` in `.scss-lint.yml`

## Are there points in the code the reviewer needs to double check?
None

## Why was this MR needed?
Improve SCSS maintainability and consistency

## Screenshots (if relevant)
None

## Does this MR meet the acceptance criteria?

- Tests
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
#23485

See merge request !7080
 2016-10-24 21:35:42 +00:00
Annabel Dunstone Gray
5a4e672178 Merge branch 'enable-scss-lint-space-around-operator' into 'master' 
Enable SpaceAroundOperator in scss-lint

## What does this MR do?
Enables `SpaceAroundOperator` in .`scss-lint.yml`

## Are there points in the code the reviewer needs to double check?
None

## Why was this MR needed?
Improve SCSS maintainability and consistency

## Screenshots (if relevant)
None

## Does this MR meet the acceptance criteria?

- Tests
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
#23485

See merge request !7078
 2016-10-24 20:40:06 +00:00
Clement Ho
791c9d0dd3 Enable SingleLinePerSelector in scss-lint 2016-10-24 15:22:06 -05:00
Clement Ho
f035cd486a Enable SpaceAfterVariableColon in scss-lint 2016-10-24 14:49:06 -05:00
Clement Ho
2004b30ed6 Enable SpaceAroundOperator in scss-lint 2016-10-24 14:29:44 -05:00
Clement Ho
5480114477 Enable trailingWhitespace in scss-lint 2016-10-24 14:23:40 -05:00
Clement Ho
e88aa25f42 Enforce TrailingSemicolon and EmptyLineBetweenBlocks in scss-lint 2016-10-14 16:28:10 -05:00
Jacob Schatz
d96a89f3b7 Remove SCSS rules for short hex chars. 2016-10-03 20:40:22 -04:00
Jacob Schatz
ed08bfdc26 Merge branch 'scss-url-linters' into 'master' 
Enable the UrlFormat and UrlQuotes SCSS Linters.

There were no lints to fix for this one, so it's just preventative.

UrlFormat: URLs should be valid and not contain protocols or domain names.

UrlQuotes: URLs should always be enclosed within quotes.

cc: @jschatz1 

See merge request !3770
 2016-04-28 19:59:53 +00:00
Connor Shea
de95ab6257
Enable the UrlFormat and UrlQuotes SCSS Linters. 2016-04-16 18:03:20 -06:00
Connor Shea
37973bc143
Enable the EmptyRule SCSS Linter. 
Prevents empty SCSS rules from being included in the SCSS.

Also fixes the handful of lints caught by the linter.
 2016-04-16 17:56:13 -06:00
connorshea
21837bfb20 Add comments to the SCSS Lint config file [ci skip] 
Also add some previously missing linters.
 2016-04-04 17:48:24 -06:00
connorshea
d80b8ed6d4 Enable SpaceBeforeBrace rule for SCSS Lint 
Also resolve all instances of spaces not being included before opening
braces.
 2016-03-30 14:30:06 -06:00
connorshea
8d7ad53561 Disabled SelectorFormat rule for SCSS Lint in order to get the Rake task passing sooner. 
Discussed in #14299.

[ci skip]
 2016-03-18 14:13:29 -06:00
connorshea
8d8b457ceb Add SCSS Lint, CSSComb config file, run SCSS Lint in GitLab CI, add documentation for SCSS Style Guide. 
See !3069 for more information.
 2016-03-14 20:33:54 -06:00