Commit Graph

5 Commits

Author SHA1 Message Date
Dmitriy Zaporozhets f928c22ff0
Return all runner tags when search is empty
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2019-06-24 16:44:04 +03:00
Alexis Reigel 28fcf5c4bf
use functional style for tags finder 2019-02-27 20:20:24 +01:00
Alexis Reigel 022ee0c0c9
don't filter tags by taggable type
Due to performance reasons we cannot use the type filter on the tags.
The table for ActsAsTaggableOn is too big and too unoptimized, such that
the queries time out on production.

See the discussion
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740#note_120087938
for more info.
2019-02-27 20:19:50 +01:00
Alexis Reigel cd063eec32
optimize sql query to get tags related to runners
The query generated by ActsAsTaggableOn `@taggable_type.all_tags` is
very inefficient (joins too much, grouping, inner select, ...).
2019-02-27 20:19:50 +01:00
Alexis Reigel 2e05292562
use lazy ajax filter dropdown for runner tags
the potential number of available runner tags is too large to load it
statically to a dropdown. we use the same lazy loaded dropdown as is
used for the users dropdown already.
2019-02-27 20:19:49 +01:00