Commit graph

14 commits

Author SHA1 Message Date
Robert Schilling
76bd09326f Use declared_params helper in API 2016-11-14 15:22:06 +01:00
Joshua Welsh
ce4760bbd5
Fixes various errors when adding deploy keys caused by not exiting the control flow.
When adding a deploy key that already exists in the project the existing key would not be returned, resulting in an attempt to create a new one, which in turn caused a 500 error due to an ActiveRecord exception.

When adding a deploy key that exists within another project the key would be joined to the project, but would also attempt to create a new one, which resulted in a 400 error due to the key already existing.

Fixes #22741
Fixes #21754

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-26 12:54:47 +02:00
Z.J. van de Weg
7e47a82899 Namespace EnableDeployKeyService under Projects 2016-08-08 20:59:51 +02:00
Z.J. van de Weg
554e18ab02 Create service for enabling deploy keys 2016-08-05 11:38:17 +02:00
Z.J. van de Weg
460065b743 Move deploy_key tests to deploy_key_spec.rb
Also, fix the failing test in the process
2016-08-04 16:55:20 +02:00
Z.J. van de Weg
2b6bd6a33f Use Grape DSL for deploy keys endpoints
Also a minor clean up of the post endpoint
2016-08-03 21:04:14 +02:00
Z.J. van de Weg
da3d3ba89c Endpoints to enable and disable deploy keys
Resolves #20123
2016-08-03 16:00:22 +02:00
Alejandro Rodríguez
0480317433 Change returns for nexts to please rubocop (behaviour is the same) 2016-07-20 13:39:34 -04:00
Alejandro Rodríguez
818ad89ea5 Add /deploy_keys API to retrieve all deploy keys regardless of project affiliation
Also, in favour of consistency, deprecate `/projects/:id/keys/...` routes in favour of
`/projects/:id/deploy_keys/...`
2016-07-20 13:39:19 -04:00
jubianchi
998cd3cb63 Improve error reporting on users API
* users (#6878, #3526, #4209): Validation error messages are now exposed through 400 responses, 409 response are sent in case of duplicate email or username
* MRs (#5335): 409 responses are sent in case of duplicate merge request (source/target branches), 422 responses are sent when submiting MR fo/from unrelated forks
* issues
* labels
* projects
2014-09-16 01:25:24 +02:00
skv
a3f645ef51 Remove deprecated finders 2014-01-19 23:39:56 +04:00
Dmitriy Zaporozhets
d636ad49bf API: set gitlab-ci service for project 2013-10-29 16:39:46 +02:00
Dmitriy Zaporozhets
73f780d640 API: Protect project deploy keys from unauthorized access 2013-09-30 16:47:26 +03:00
Dmitriy Zaporozhets
b05600f28b Split Project api on several parts: deploy_keys, hooks, snippets etc 2013-06-06 12:37:51 +03:00