Commit graph

12 commits

Author SHA1 Message Date
Luke Duncalfe
37b17fa61a Add service classes for mutating AwardEmoji
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
2019-08-21 11:39:41 +12:00
gfyoung
73322a0e55 Enable frozen string in app/controllers/**/*.rb
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
2018-09-18 21:22:45 -07:00
Chantal Rollison
009c4f7fb8 Allows author to vote on their own issue 2018-08-24 10:13:41 +00:00
Jarka Kadlecova
8c3a03c1b9 Display comments for personal snippets 2017-05-02 13:07:53 +02:00
Rémy Coutable
beedd40ef7
Ensure user is authenticated to create a new snippet
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-11-28 16:57:49 +01:00
Z.J. van de Weg
412ff80b7b Start Frontend work, fix routing problem 2016-09-19 19:50:40 +03:00
Z.J. van de Weg
25004cbc32 Snippets get award emoji! 👍 2016-09-19 19:47:43 +03:00
barthc
29f818e616 prevent authored awardable thumbs votes 2016-08-30 20:57:47 +01:00
barthc
7687237237 prevent authored awardable thumbs votes
prevent authored awardable thumbs votes

prevent authored awardable thumbs votes
2016-08-28 18:15:55 +01:00
ZJ van de Weg
2f9c2149a3 Backend awardables on comments 2016-06-06 11:03:39 +02:00
ZJ van de Weg
e0cabb67d0 Fix latests concerns 2016-05-18 08:47:15 -05:00
Zeger-Jan van de Weg
3bdc57f0a7 Create table for award emoji 2016-05-06 10:47:11 +02:00