Jacopo
0ce6785851
Replaces tag: true into :tag in the specs
...
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
2017-10-07 13:57:54 +02:00
Robert Speicher
9513bd18c4
Ensure all project factories use :repository trait or :empty_project
2017-08-01 14:51:52 -04:00
Keifer Furzland
7e113b6824
Remove superfluous type defs in specs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Rémy Coutable
05e152fa7f
Fix the :project factory by not copying the test repo twice
...
Also, fixing some calls to the :project factory with the :test_repo
trait since this trait is already included in the :project factory.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 09:58:06 +02:00
Robert Speicher
9eeba8fb49
Auto-correct ProjectPathHelper violations
2017-07-06 12:20:50 -04:00
Robert Speicher
e939bf7be1
Change gitlab_sign_in to sign_in where possible
2017-06-29 12:18:23 -04:00
Robert Speicher
45fb1f9542
Change login_as uses to gitlab_sign_in
2017-06-19 18:59:01 -05:00
Douwe Maan
b38c74d696
Revert 'New file from interface on existing branch'
2017-06-09 10:10:47 -05:00
Oswaldo Ferreira
2338785ec9
Use wait_for_requests to wait all JS request
2017-05-22 20:39:49 -03:00
Jacopo
ff76adb547
Unnecessary "include WaitForAjax" and "include ApiHelpers"
...
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Jose Ivan Vargas
7592137f21
Fix rspec and spinach tests
2017-04-06 14:58:57 -05:00
Eric Eastwood
b42dc1a52b
Linking to edit file directly
2017-04-06 16:36:38 +00:00
Douwe Maan
742cee756b
Merge branch 'jej-22869' into 'security'
...
Fix information disclosure in `Projects::BlobController#update`
It was possible to discover private project names by modifying `from_merge_request`parameter in `Projects::BlobController#update`. This fixes that.
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md ) entry added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html )
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides )
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits )
https://gitlab.com/gitlab-org/gitlab-ce/issues/22869
See merge request !2023
2016-11-28 21:25:18 -03:00
