Commit Graph

15 Commits

Author SHA1 Message Date
Sam Rose 804198ab7f Maintain milestone filter option when updating filter
Setup teaspoon tests for Issuable
2016-12-21 07:34:58 -05:00
Fatih Acet b01a830afe Merge branch '24877-bulk-edit-only-keeps-common-labels-when-searching' into 'master'
Improve bulk assignment

This MR improves current implementation of Label dropdown when used for bulk assignment on issuable pages (/:namespace/:project/issues, /:namespace/:project/merge_requests)

Previously this dropdown relied on `<input>` tags to get its active items and also to calculate items with indeterminate state.

Relying on `<input>` tags is not enough when we want to set/get multiple states on a dropdown.

For this case we want to get/set:

- Marked items 
- Unmarked items that were initially marked
- Unmarked items that were initially indeterminate
- Items with indeterminate state.

This MR makes the Label dropdown to save its own state as `data` so it will be easy to get and set whatever state we want no matter if the dropdown is filtering which is the issue that I initially wanted to solve as you can see in the following gif.

**Before** 
![2016-12-07_11.44.48](/uploads/cb697161b8b39cdee72fdbb95a531100/2016-12-07_11.44.48.gif)

**After**
![2016-12-07_11.32.43](/uploads/338255a302de0dd1367474f33232d2a3/2016-12-07_11.32.43.gif)

As you can see in the first gif the `bug` label is removed from the selected issues but the `enhancement` label should set but the `critical` should be kept. This is fixed on the next gif.

Fixes #24877

See merge request !7765
2016-12-15 21:03:33 +00:00
Alfredo Sumaran 262fc28a7d Improve issuable's bulk assignment implementation
This fixes the case when the user wants to add a label. The user has to use the dropdown’s filter input to look for a label and click it in order to see the bug.

Step to reproduce

- Select at least two issues, one label should be present in all issues, other label should be present in at least one.

- On the label dropdown: Deselect label that is present in all issues, look for another issue using the filter input and click it.

- Click on `Update issues`

Before: Unmarked label were kept on selected issues.
Now: Unmarked label is removed from selected issues
2016-12-14 10:05:00 -05:00
Mike Greiling 23f5865e18 expand remaining non-explicit eslint-disable blocks and factor out globals when no-undef encountered 2016-12-13 21:07:31 -06:00
tiagonbotelho 011e561bfa implements reset incoming email token on issues modal and account page,
reactivates all tests and writes more tests for it
2016-11-07 15:56:18 +00:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Bryce Johnson f1bb7ddfa7 Ensure search val is defined. 2016-10-25 12:46:28 +02:00
Bryce Johnson 995d4df151 Ensure cursor is applied to end of issues search input. 2016-10-25 11:11:11 +02:00
Bryce Johnson e0a79ab4e8 Increase debounce wait on issues search execution. 2016-10-25 11:11:11 +02:00
Phil Hughes cc88fa4d5b Merge branch 'master' into revert-c676283b 2016-10-03 09:10:20 +01:00
Bryce 726071e60a Intercept issues search form submit to preserve filters. 2016-09-22 11:19:18 +02:00
barthc 418e95bd5f fix issues mr counter 2016-09-20 14:39:15 +01:00
Jared Deckard 7f6474b269 Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
Dmitriy Zaporozhets f28ca293b7 Add bulk update support for merge requests list
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-09-08 11:52:20 +03:00
Bryce 1750fe3210 Add issues filters reset btn (ES6-ified).
(Also refactored checkChanged slightly.)
2016-09-02 20:30:34 +02:00