gitlab-org--gitlab-foss

Commit Graph

Author	SHA1	Message	Date
Robert Schilling	96a49c79aa	API: Support dots in wiki slugs	2019-01-15 09:02:00 +01:00
Rémy Coutable	4af9d592c5	Replace factory_girl_rails with factory_bot_rails I've followed the [upgrade guide](https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md) and ran these two commands: ``` grep -e FactoryGirl */.rake */.rb -s -l \| xargs sed -i "" "s\|FactoryGirl\|FactoryBot\|" grep -e factory_girl */.rake */.rb -s -l \| xargs sed -i "" "s\|factory_girl\|factory_bot\|" ``` Signed-off-by: Rémy Coutable <remy@rymai.me>	2017-12-14 15:01:55 +01:00
Mark Fletcher	a616b475b1	Add tests for WikiPages services * Alter wiki_pages factory with custom creation operation	2017-02-14 11:16:34 +05:30
Timothy Andrew	8e71c19a69	Implement the correct linking behaviour in `WikiLinkFilter`. Original Comments ================= - Linking behaves as per rules documented here: https://gitlab.com/gitlab-org/gitlab-ce/blob/16568-document-wiki-linking-behavior/doc/markdown/wiki.md - All links (to other wiki pages) are rewritten to be at the level of the app root. We can't use links relative to the current page ('./foo', 'foo', '../foo'), because they won't work in the markdown preview, where the current page is suffixed with `/edit` - Move existing `WikiLinkFilter` specs to `WikiPipeline` spec. It makes sense to run these tests on the combined output of the pipeline, rather than a single filter, since we can catch issues with conflicting filters. - Add more tests to cover the new linking @rymai's Review =============== - Classes nested under `WikiLinkFilter` should declare `WikiLinkFilter`'s inherit, so nothing changes if the nested class is loaded first. - Add a blank line after a guard clause - Use keyword arguments for the `Rewriter` constructor - Invert a condition - use `if` instead of `unless` - Inline a `let` in `WikiPipeline` spec - it was only used in a single place - Change out of date spec names - Add a comment for every rewrite rule in `Rewriter`	2016-06-09 10:04:15 +05:30
Sebastian Klier	edd07e2363	Fix wiki tests	2016-04-20 08:25:41 +08:00

5 Commits