Commit graph

8 commits

Author SHA1 Message Date
Rémy Coutable
0eea8c8857 Support slash commands in noteable description and notes
Some important things to note:

- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
  params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
  the right place for advanced logic that has nothing to do with what
  models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
  only
- the `/merge` command is not handled yet

Other improvements:

- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-08-13 00:05:57 +02:00
Lin Jen-Shin
0671db52a8 Use keyword args to be more clear:
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12566374
2016-06-20 19:11:42 +08:00
Lin Jen-Shin
c491f66952 Use a separate line for separate actions:
Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12420487
2016-06-20 17:58:05 +08:00
Lin Jen-Shin
09c38e46e5 Only pass item name 2016-06-15 20:10:16 +08:00
Lin Jen-Shin
fcc6a59247 Blank line for private 2016-06-15 16:18:31 +08:00
Lin Jen-Shin
cb168c347a Remove empty lines at the beginning of files 2016-06-15 15:47:40 +08:00
Lin Jen-Shin
c64cd113cc Add ! for verify_record! because it could raise 2016-05-21 09:46:27 -07:00
Lin Jen-Shin
75415663f8 Rename handlers and introduce Handler.for 2016-05-21 09:40:08 -07:00