Bob Van Landuyt
f3f1df1476
Add a cop for FinderMethods
...
This notifies developers when calling `find(_by!)` chained on
`execute`. And suggests using the methods from `FinderMethods`. These
will perform the correct authorization checks on the resource when it
is found.
2018-06-20 18:13:13 +02:00
blackst0ne
27c95364b5
Replace '.team << [user, role]' with 'add_role(user)' in specs
2017-12-22 19:18:28 +11:00
Lin Jen-Shin
412db1874f
Fix some tests and report the error message
2017-08-09 21:41:45 +08:00
Rémy Coutable
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Rémy Coutable
3db37e0562
Enable the Style/TrailingCommaInArguments cop
...
Use the EnforcedStyleForMultiline: no_comma option.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Sean McGivern
5069682d8e
Enable RSpec/FilePath cop
...
- Ignore JS fixtures
- Ignore qa directory
- Rewrite concern specs to put concern name first
2017-04-26 12:50:32 +01:00
Douwe Maan
79889a6aa3
Add specs
2017-04-05 17:44:14 +01:00
Robert Speicher
ca9a79f620
Use :empty_project where possible in service specs
2017-03-27 20:44:09 -04:00
Bob Van Landuyt
ea70a0d674
Rename variable
...
merge_request_for_resolving_discussions ->
merge_request_to_resolve_discussions_of
2017-03-13 08:27:52 +01:00
Bob Van Landuyt
67bd277ae6
Make sure the for a merge request only gets executed once.
2017-03-13 08:27:51 +01:00
Bob Van Landuyt
ffe135ccf6
Move functionality for resolving discussions into a concern
2017-03-13 08:27:51 +01:00
