Commit graph

11 commits

Author SHA1 Message Date
Tiger
fc8c1a77d3 Validate session key when authorizing with GCP to create a cluster
It was previously possible to link a GCP account to another
user's GitLab account by having them visit the callback URL,
as there was no check that they were the initiator of the
request.

We now reject the callback unless the state parameter
matches the one added to the initiating user's session.
2019-02-19 17:21:08 +11:00
gfyoung
be42c05054 Enable more frozen string in app/controllers/
Enables frozen string for the following:

* app/controllers/dashboard/**/*.rb
* app/controllers/explore/**/*.rb
* app/controllers/google_api/**/*.rb
* app/controllers/groups/**/*.rb
* app/controllers/import/**/*.rb
* app/controllers/instance_statistics/**/*.rb
* app/controllers/ldap/**/*.rb
* app/controllers/oauth/**/*.rb
* app/controllers/profiles/**/*.rb

Partially addresses #47424.
2018-09-23 12:48:02 -07:00
Kamil Trzcinski
f9d490dbb9 Improve redirect uri state and fix all remaining tests 2017-10-06 16:14:14 +02:00
Shinya Maeda
f293288589 Security fix: redirection in google_api/authorizations_controller 2017-10-06 21:28:40 +09:00
Kamil Trzcinski
0fbe0406fd Change /google_api/authorizations/ to /google_api/auth/. 2017-10-05 17:44:11 +02:00
Shinya Maeda
fe135fac68 authorizations_controller_spec. cluster_policy_spec. 2017-10-05 21:29:22 +09:00
Shinya Maeda
2cb1d617d9 Use expires_in for access_token validation 2017-10-02 17:13:46 +09:00
Shinya Maeda
e499c1c39d Replace reactive_cache by multipel sidekiq workers 2017-10-01 00:54:22 +09:00
Shinya Maeda
bda1b0a878 Databse foreing key, index, encrypt password. Use short path. Improve error handling. Polish. 2017-09-29 00:08:11 +09:00
Shinya Maeda
bdc618c289 ok 2017-09-26 02:11:26 +09:00
Shinya Maeda
d4fa672c20 Create Kubernetes cluster on GKE from k8s service 2017-09-25 16:10:25 +09:00