fee6e478d6
Merge branch 'security-approval-race-condition' into 'master'
...
Add ApplicationRecord#safe_ensure_unique method
See merge request gitlab/gitlabhq!3054
2019-04-25 10:39:09 +00:00
650f40865e
Forbid the use of `#reload` and prefer `#reset`
...
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.
The `#reset` seems to solve exactly that case.
2019-04-15 13:05:14 +02:00
208338fde6
Add ApplicationRecord#safe_ensure_unique method
...
Port of https://dev.gitlab.org/gitlab/gitlab-ee/merge_requests/866
to CE excluding the migration and service changes as they don't
apply to CE.
2019-04-12 12:19:47 +08:00
f086dbf66e
Add a thin encapsulation around .pluck(:id)
2019-03-28 16:18:23 +00:00
c982edfa19
Avoid race conditions when creating GpgSignature
...
This avoids race conditions when creating GpgSignature.
2019-02-06 15:24:46 +01:00
ccd8a9b282
Adds helper for `find_or_create_by` in transaction
...
This allows us to call `find_or_create_by` on all models and scopes.
2019-02-05 14:44:41 +01:00
d253440ed1
Add query method for id query
2019-01-15 17:10:30 +08:00
648f05622d
Add ApplicationRecord model class
...
In Rails 5 all models by default inherit from ApplicationRecord.
2018-11-14 12:41:16 +01:00
GitLab Release Tools Bot