Commit graph

9 commits

Author SHA1 Message Date
George Tsiolis
579fa8b8ec Rename CI related selectors 2019-04-16 12:57:07 +03:00
Stan Hu
39f252254b Make sure there's only one slash as path separator
In Ruby 2.4, `URI.join("http://test//", "a").to_s` will
remove the double slash, however it's not the case in
Ruby 2.5. Using chomp should work better for the intention,
as we're not trying to allow things like ../ or / paths
resolution.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53180
2018-11-09 15:36:45 -08:00
gfyoung
32af384adf Enable frozen string in rest of app/models/**/*.rb
Partially addresses #47424.
2018-08-10 00:51:01 -07:00
Francisco Javier López
840f80d48b Add validation to webhook and service URLs to ensure they are not blocked because of SSRF 2018-06-01 11:43:53 +00:00
Douwe Maan
95ced3bb5f Merge branch 'fj-15329-services-callbacks-ssrf' into 'security-10-6'
Server Side Request Forgery in Services and Web Hooks

See merge request gitlab/gitlabhq!2337
2018-03-21 14:39:21 +00:00
Jarka Kadlecova
84c68bb140 Address MR comments 2017-06-01 07:47:16 +02:00
Jarka Kadlecova
33d82ccb45 simplify test&save actions when setting a service integration 2017-06-01 07:47:15 +02:00
Rémy Coutable
d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Eric Eastwood
1c85d86d19 Add MockCiService integration
MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9250/

See https://gitlab.com/madlittlemods/gl-mock-ci-service
2017-02-24 20:01:36 -06:00