gitlab-org--gitlab-foss

Commit Graph

Author	SHA1	Message	Date
Douglas Barbosa Alexandre	100e3e7601	Fix sorting issues/mrs by votes on the groups page The `non_archived` scope applied here https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/controllers/conc erns/issues_action.rb#L5 overrides the previous `ORDER BY` applied inside the IssuesFinder, with the default scope of the Project model, resulting in SQL errors.	2016-03-21 17:01:38 -03:00
Robert Speicher	a7c4d0da8c	Make the `/groups` route behave as expected The route is supposed to redirect the Groups#index request based on whether or not a user was logged in. If they are, we redirect them to their groups dashboard; if they're not, we redirect them to the public Explore page. But due to overly aggressive `before_action`s that weren't excluding the `index` action, the request always resulted in a 404, whether a user was logged in or not. Closes #12660	2016-01-23 16:10:13 -08:00

Author

SHA1

Message

Date

Douglas Barbosa Alexandre

100e3e7601

Fix sorting issues/mrs by votes on the groups page

The `non_archived` scope applied here
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/controllers/conc
erns/issues_action.rb#L5 overrides the previous `ORDER BY` applied
inside the IssuesFinder, with the default scope of the Project model,
resulting in SQL errors.

2016-03-21 17:01:38 -03:00

Robert Speicher

a7c4d0da8c

Make the `/groups` route behave as expected

The route is supposed to redirect the Groups#index request based on
whether or not a user was logged in. If they are, we redirect them to
their groups dashboard; if they're not, we redirect them to the public
Explore page.

But due to overly aggressive `before_action`s that weren't excluding the
`index` action, the request always resulted in a 404, whether a user was
logged in or not.

Closes #12660

2016-01-23 16:10:13 -08:00

2 Commits