Commit graph

9 commits

Author SHA1 Message Date
Semyon Pupkov
7b98257453 Fix ConstantName rubocop offense 2018-12-09 22:45:48 +05:00
gfyoung
c858f70d07 Enable frozen string for lib/gitlab/*.rb 2018-10-22 07:00:50 +00:00
Rubén Dávila
7044a3a54a Validate SSH keys through the sshkey gem 2018-02-16 11:32:08 -05:00
Rubén Dávila
75fd832454 Revert "Merge branch 'rd-43185-revert-sanitize-extra-blank-spaces-used-when-uploading-a-ssh-key' into 'master'"
This reverts commit e607fd796657afd214b8f25201919d3e33b3f35f.
2018-02-15 09:50:19 -05:00
Rubén Dávila
740499bab5 Revert "Merge branch 'rd-40552-gitlab-should-check-if-keys-are-valid-before-saving' into 'master'"
This reverts commit a58f8c32c6, reversing
changes made to cd5d75c362.
2018-02-12 12:39:47 -05:00
Rubén Dávila
972f564dcd Sanitize extra blank spaces used when uploading a SSH key 2018-02-01 17:00:16 -05:00
Nick Thomas
b84ca08e35 Address review comments 2017-08-30 20:50:44 +01:00
Nick Thomas
6847060266 Rework the permissions model for SSH key restrictions
`allowed_key_types` is removed and the `minimum_<type>_bits` fields are
renamed to `<tech>_key_restriction`. A special sentinel value (`-1`) signifies
that the key type is disabled.

This also feeds through to the UI - checkboxes per key type are out, inline
selection of "forbidden" and "allowed" (i.e., no restrictions) are in.

As with the previous model, unknown key types are disallowed, even if the
underlying ssh daemon happens to support them. The defaults have also been
changed from the lowest known bit size to "no restriction". So if someone
does happen to have a 768-bit RSA key, it will continue to work on upgrade, at
least until the administrator restricts them.
2017-08-30 20:50:44 +01:00
Nick Thomas
b0f982fbdf Add settings for minimum key strength and allowed key type
This is an amalgamation of:

* Cory Hinshaw: Initial implementation !5552
* Rémy Coutable: Updates !9350
* Nick Thomas: Resolve conflicts and add ED25519 support !13712
2017-08-30 20:50:44 +01:00