kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
91896 commits 1 branch 0 tags 899 MiB
Commit graph

22 commits

Author SHA1 Message Date
Stan Hu
41b51c0656 Encode Content-Disposition filenames 
Users downloading non-ASCII attachments would see garbled characters.
When used with object storage, AWS S3 would return an InvalidArgument
error: Header value cannot be represented using ISO-8859-1.

Per RFC 5987 and RFC 6266, Content-Disposition should be encoded
properly. This commit takes the Rails 6 implementation of
ActiveSuppport::Http::ContentDisposition
(https://github.com/rails/rails/pull/33829) and ports it here.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673
 2019-02-04 23:12:44 -08:00
blackst0ne
b44a2c801a Update specs to rails5 format 
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
 2018-12-19 10:04:31 +11:00
Kamil Trzciński
5da2f42dc9 backport: Always proxy reports downloads 
This makes to always proxy reports
 2018-11-07 21:49:45 +01:00
Jasper Maes
cf0a61c202 Rails5: fix artifacts controller download spec 
Rails5 has params[:file_type] as '' if file_type is included as nil
in the request
 2018-10-04 21:54:01 +02:00
Matija Čupić
48c911b75e CE Resolve "Refactor code quality similar to JUnit tests" 2018-10-02 17:01:26 +00:00
Micaël Bergeron
960b6337cb fix specs 2018-03-07 15:23:17 -05:00
Micaël Bergeron
a85948862e fix some broken specs 2018-03-06 16:19:24 -05:00
Sean McGivern
a7dae52e9d Merge branch '4163-move-uploads-to-object-storage' into 'master' 
Move uploads to object storage

Closes #4163

See merge request gitlab-org/gitlab-ee!3867
 2018-02-28 20:58:15 +01:00
Kamil Trzciński
45d2c31643 Merge commit '4b92efd90cedaa0aff218d11fdce279701128bea' into object-storage-ee-to-ce-backport 2018-02-28 20:46:53 +01:00
Grzegorz Bizon
6ca02a4150 Merge branch 'zj-multiple-artifacts-ee' into 'master' 
Multiple artifacts ee

See merge request gitlab-org/gitlab-ee!3276
 2018-02-28 20:44:09 +01:00
Kamil Trzciński
e3fafa7632 Merge commit 'f2f58a60b76acd479e37bdbc9246ec9f9b2bea82' into object-storage-ee-to-ce-backport 2018-02-28 20:36:07 +01:00
Kamil Trzciński
e0401df121 Merge commit '11c67e7c2f992299ff5918ce67995b73d1e0be6d' into object-storage-ee-to-ce-backport 2018-02-28 20:35:22 +01:00
Douwe Maan
bc76062774 Merge branch 'jej/lfs-object-storage' into 'master' 
Can migrate LFS objects to S3 style object storage

Closes #2841

See merge request !2760
 2018-02-28 20:29:37 +01:00
Lin Jen-Shin
f94df424ae Just use the tests from EE 2017-12-26 18:27:03 +08:00
Jacopo
2f40dac352 Refactor have_http_status into have_gitlab_http_status in the specs 2017-10-20 10:13:18 +02:00
Zeger-Jan van de Weg
e4d07f12b6
Test against public projects 2017-10-05 12:41:22 +02:00
Zeger-Jan van de Weg
d5486807ba
Incorporate feedback 2017-10-04 21:01:27 +02:00
Zeger-Jan van de Weg
8cbfe3aea6
Redirect to pages daemon 2017-10-03 12:34:24 +02:00
Grzegorz Bizon
deaa7f54e0 Fix artifacts controller specs 2017-09-06 14:27:42 +02:00
Douwe Maan
fe13f11041 Create and use project path helpers that only need a project, no namespace 2017-07-05 11:11:59 -05:00
Lin Jen-Shin
71777a4a18 Rename BuildsController to JobsController 
Rename other URL generators

admin_builds_path -> admin_jobs_path

Fix tests and more renaming

Fix more tests

Also change build_id to job_id in the controller
 2017-05-17 20:17:30 +08:00
Douwe Maan
0f58eb6bde Add artifact file page that uses the blob viewer 2017-05-04 08:50:12 -05:00