5e9e56924a
Merge branch 'security-10-4-25223-snippets-finder-doesnt-obey-feature-visibility' into 'security-10-4'
...
[Port for security-10-4]: Makes SnippetFinder ensure feature visibility
2018-02-09 12:04:05 -06:00
27c95364b5
Replace '.team << [user, role]' with 'add_role(user)' in specs
2017-12-22 19:18:28 +11:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
19e91e4ba9
Use `described_class` in SnippetsFinder-spec
2017-05-10 16:48:18 +02:00
ad309f5d11
Merge branch 'snippets-finder-visibility' into 'security'
...
Refactor snippets finder & dont return internal snippets for external users
See merge request !2094
2017-05-10 16:48:18 +02:00
d49768296c
Auto-correct `RSpec/DescribedClass` violations
2017-05-01 11:13:33 -04:00
01b767bd98
Merge branch '19990-update-snippets-page-design' into 'master'
...
Resolve "Updated UI for Snippets pages"
## What does this MR do?
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html ) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md )
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html )
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides )
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits )
## What are the relevant issue numbers?
Closes #19990
See merge request !7861
2016-12-12 18:06:20 +00:00
dccd53e1ce
add new tests for snippets_finder.rb
2016-12-10 00:57:23 -06:00
fde754e267
API: Endpoint to expose personal snippets as /snippets
...
Adding the necessary API for the new /snippets Restful resource
added with this commit. Added a new Grape class `Snippets`, as
well as a `PersonalSnippet` entity.
Issue: #20042
Merge-Request: !6373
Signed-off-by: Guyzmo <guyzmo+gitlab+pub@m0g.net>
2016-12-01 19:07:49 +01:00
9e211091a8
Enable Style/EmptyLines cop, remove redundant ones
2016-07-01 21:56:17 +02:00
31266c5be4
Address feedback
2016-03-22 00:09:20 +01:00
8b830b8c3b
Fix specs
2016-03-18 21:04:53 -03:00
b900304c38
Make better use of the `visibility_level` factory traits
2016-03-08 16:40:45 -05:00
0c4a70a306
Updated rspec to rspec 3.x syntax
...
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12 19:17:35 +01:00
7f97a1277d
internal snippets: fix exposing of title
2014-10-24 19:39:14 +03:00
47f539f5a6
Snippets: public/internal/private
2014-10-09 17:09:53 +03:00
Douwe Maan