Commit graph

11 commits

Author SHA1 Message Date
Thong Kuah
89f7bac3ba Comment why we can't use Gitlab::CurrentSettings
See https://gitlab.com/gitlab-org/gitlab-ee/issues/9833
2019-02-20 10:50:58 +13:00
Bob Van Landuyt
7e55a227a5 Revert "Merge branch 'use_gitlab_current_settings' into 'master'"
This reverts merge request !25370
2019-02-19 12:58:05 +00:00
Thong Kuah
8a1b6041c8 Use Gitlab::CurrentSettings in UrlValidator
Gitlab::CurrentSettings will create ApplicationSetting.current if not
present which means we don't have to use `&.`. We can also more easily
use stub_application_setting in specs
2019-02-19 22:04:08 +13:00
Reuben Pereira
f40b5860d7 Add table and model for error tracking settings 2019-01-07 17:55:21 +00:00
James Edwards-Jones
72c0059407 Allow URLs to be validated as ascii_only
Restricts unicode characters and IDNA deviations
which could be used in a phishing attack
2018-12-06 15:18:18 +00:00
Nick Thomas
b73f3ce58f
Allow UrlValidator to work with attr_encrypted 2018-09-17 19:34:40 +01:00
gfyoung
720ed6f6ab Enable frozen string in apps/validators/*.rb
Partially addresses #47424.
2018-06-27 09:48:37 -07:00
Francisco Javier López
1418afc2d6 Avoid checking the user format in every url validation 2018-06-11 13:29:37 +00:00
Francisco Javier López
840f80d48b Add validation to webhook and service URLs to ensure they are not blocked because of SSRF 2018-06-01 11:43:53 +00:00
evuez
4d0e2979b9 Allow webhooks URL to have leading and trailing spaces 2016-02-26 14:34:06 -05:00
Robert Speicher
d5ea93469b Add custom UrlValidator 2015-12-07 16:57:26 -05:00