Commit graph

10 commits

Author SHA1 Message Date
Nick Thomas
8d2e1b724b Merge branch '54786-mr-empty-file-display' into 'master'
Display empty files properly on MR diffs

Closes #54786

See merge request gitlab-org/gitlab-ce!23671
2018-12-15 12:21:54 +00:00
Sean Nichols
9f9eb03f3d Fix diff table rendering for empty files and improve tests 2018-12-13 23:52:31 -05:00
Oswaldo Ferreira
ed3034bbb7 Allow suggesting single line changes in diffs 2018-12-13 19:17:19 +00:00
Sean Nichols
4d2448e03a Add tests and move empty file message into own component 2018-12-13 01:49:32 -05:00
Phil Hughes
234563ba30
Made diff & note data consistent
This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.

This changes that & makes it consistent with what it returned from the
API, snake case.
2018-11-14 19:16:46 +00:00
Phil Hughes
35faecb06b
Restored width & height properties 2018-11-06 10:17:59 +00:00
Phil Hughes
f7df9ddb52
Re-implemented image commenting on diffs
This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.

With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.

Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash & the X & Y position of
the comment form.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
2018-11-05 14:02:41 +00:00
Oswaldo Ferreira
caf10464c0 Fix LFS uploaded images not being rendered 2018-10-05 22:36:20 +00:00
Tim Zallmann
53f77cfee1 Added Diff Viewer to new VUE based MR page 2018-06-26 18:49:22 +00:00
Felipe Artur
3e66795ef1 Changes tab VUE refactoring 2018-06-21 12:22:40 +00:00