Commit graph

14 commits

Author SHA1 Message Date
Winnie Hellmann
3db2f32759 Enable Capybara/FeatureMethods cop 2018-07-05 06:32:05 +00:00
Alexis Reigel
197932a222
allow only png, ico for favicon uploads
the related omnibus graphicsmagick package only supports those formats.

see https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1975
2018-06-05 16:20:24 +02:00
Alexis Reigel
b4d84c07bc
remove favicon preview on appearance page 2018-06-05 16:20:22 +02:00
Alexis Reigel
9e14f437b6
create favicon overlay on the client
the initial reason for this change was that graphicsmagick does not
support writing to ico files. this fact lead to a chain of changes:

1. use png instead of ico (browser support is good enough)
2. render the overlays on the client using the canvas API. this way we
   only need to store the original favion and generate the overlay versions
   dynamically.
   this change also enables (next step) to simplify the handling of the
   stock favicons as well, as we don't need to generate all the versions
   upfront.
2018-06-05 16:20:21 +02:00
Alexis Reigel
85a8e6f26a
whitelist allowed file types for custom favicons 2018-06-05 16:20:20 +02:00
Alexis Reigel
40d8d7df4b
feature spec for managing appearance > favicon 2018-06-05 16:20:19 +02:00
Markus Koller
b8a3931925
Add custom brand text on new project pages 2017-12-04 17:22:59 +01:00
Keifer Furzland
7e113b6824 Remove superfluous type defs in specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Tim Zallmann
52b8a0db68 Resolve "Lazy load images on the Frontend" 2017-07-24 17:36:52 +00:00
Bob Van Landuyt
458f3cf9b0 Update specs for new upload path 2017-07-18 15:38:54 +02:00
Robert Speicher
e939bf7be1 Change gitlab_sign_in to sign_in where possible 2017-06-29 12:18:23 -04:00
Robert Speicher
45fb1f9542 Change login_as uses to gitlab_sign_in 2017-06-19 18:59:01 -05:00
DJ Mountney
1d1363e2bb Bring in security changes from the 9.2.5 release
Ran:
 - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
 - git checkout -b 9-2-5-security-patch origin/v9.2.2
 - git apply patchfile.patch
 - git commit
 - [Got the sha ref for the commit]
 - git checkout -b upstream-9-2-security master
 - git cherry-pick <SHA of the patchfile commit>
 - [Resolved conflicts]
 - git cherry-pick --continue
2017-06-07 21:16:20 -07:00
jurre
a0c48ec62b Move Admin Appearance spinach feature to rspec 2016-12-19 17:41:54 +01:00