Commit Graph

6 Commits

Author SHA1 Message Date
Stan Hu a0856cf7b9 Fix BitbucketServer::Client failing with Webmock 3.5.1
Webmock 3.1.0 changed the behavior to return `nil` for the body if an
HTTP 204 No Content response were received
(b837e64278).

Update the Bitbucket Server connection to ignore these No Content
response codes.
2019-02-16 15:30:02 -08:00
Stan Hu 660dcd5b7c Fix Bitbucket Server importer error handling
The importer would display a 500 error page if you attempted to import
using a non-existent DNS entry. This commit rescues known network issues
and consolidates them into
BitbucketServer::Connection::ConnectionError`.  The previous error
handling in the paginator doesn't work because it returns a lazy
collection.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56154
2019-01-12 22:14:08 -08:00
Stan Hu 5b6d5301d9 Paginate Bitbucket Server importer projects
To prevent delays in loading the page and reduce memory usage, limit the
number of projects shown at 25 per page.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/50021
2018-11-07 11:37:46 -08:00
Stan Hu d2fd6d2351 Deal with subpaths and trailing slashes properly 2018-07-31 21:14:36 -07:00
Stan Hu ae6b48d20f Fix failing spec in spec/lib/bitbucket_server/client_spec.rb 2018-07-28 17:09:10 -07:00
Stan Hu 3f715bb438 Consolidate server errors and add specs 2018-07-26 23:05:22 -07:00