Commit Graph

21 Commits

Author SHA1 Message Date
GitLab Bot 0a850868df Add latest changes from gitlab-org/gitlab@master 2019-10-09 12:06:13 +00:00
GitLab Bot 4309992515 Add latest changes from gitlab-org/gitlab@master 2019-09-26 21:06:29 +00:00
Mayra Cabrera 3e619d1f9e Refactors rack attack requests spec
* Creates a shared_examples files under shared_examples/requests
* Moves web specs into the shared examples file
* Moves let definitions to the block that uses them
2019-09-05 21:15:55 +00:00
Stan Hu e632ae8084 Standardize remote_ip and path keys for auth.log and api_json.log
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
2019-08-20 18:12:28 +00:00
Mayra Cabrera fc85b07a27 Include user id and username in auth log
Fetches user based on the value of 'rack.attack.match_discriminator'

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62756
2019-07-02 19:48:06 +00:00
Mayra Cabrera ed8ebc635a Changes RackAttack logger to use structured logs
Creates a new filename to register auth logs.
This change should allow SRE's queries to make better queries
through logging infrastructure.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54528
2019-05-24 00:45:02 +00:00
Jasper Maes 624a1cdab4 Upgrade Rails to 5.1.6.1
Model.new.attributes now also returns encrypted attributes.
2019-04-23 08:31:23 +08:00
Jasper Maes dc1eb2c5c3 Fix deprecation: Using positional arguments in integration tests 2018-12-22 14:42:41 +01:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Imre Farkas 20dfe25c15 Export assigned issues in iCalendar feed 2018-05-31 14:01:04 +00:00
Francisco Javier López 5ddd576c7e Remove internal api calls from the rack::attack throttling 2018-02-15 16:54:36 +00:00
Francisco Lopez 29521a313a Change the rss url guard clause 2017-11-17 10:02:11 +01:00
Francisco Lopez 374179a970 Removing private token 2017-11-17 10:01:21 +01:00
Francisco Lopez 470b5dc326 Updated refactor and pushing to see if test fails 2017-11-17 10:00:48 +01:00
Francisco Lopez c491b9505a Pushing to see how this tests behaves 2017-11-17 10:00:08 +01:00
Michael Kozono 987e7b7744 Add link to discussion 2017-11-17 09:58:18 +01:00
Michael Kozono 91628170c7 Remove extra attempts
Get the tests deterministic or bust!

Also, explain what the constants are doing and why. And don’t output the log message if it doesn’t apply.
2017-11-17 09:58:18 +01:00
Michael Kozono 203e3b2d07 Dry up URLs and get args construction 2017-11-17 09:58:18 +01:00
Michael Kozono 6c5f46ace2 Prevent affecting other tests 2017-11-17 09:58:18 +01:00
Michael Kozono 6ba13b41ff Refactor application setting management 2017-11-17 09:58:18 +01:00
Michael Kozono a7243fc14b Fix Rubocop offenses 2017-11-17 09:58:18 +01:00