Commit graph

15 commits

Author SHA1 Message Date
GitLab Bot
1808454313 Add latest changes from gitlab-org/gitlab@master 2020-01-31 12:08:33 +00:00
Oswaldo Ferreira
7cf4947792 Cache diff highlight in discussions
This commit handles note diffs caching, which considerably improves
the performance on merge requests with lots of comments.
Important to note that the caching approach taken here is different
from `Gitlab::Diff::HighlightCache`. We do not reset the whole cache
when a new push is sent or anything else. That's because discussions
diffs are persisted and do not change.
2018-12-21 16:59:21 -02:00
Douwe Maan
047b7e506e
Allow truncated_diff_lines to be called on image diff discussion 2018-12-20 16:40:51 +01:00
Tiago Botelho
7385e7cd47
Backports changes made to One notification per code review
The EE merge request can be found here:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8442
2018-12-07 14:24:37 +00:00
gfyoung
15b878e27e Enable more frozen string in app/models/**/*.rb
Partially addresses #47424.
2018-08-07 00:37:36 -07:00
Sean McGivern
382421a9be Fix truncated_diff_lines for legacy notes without a line
It appears that some legacy diff notes on GitLab.com have invalid line codes,
which means truncated_diff_lines won't work. This is just a band-aid solution,
as neither the diff nor the discussion will display correctly for these notes,
but they won't cause a 500 error.
2018-01-30 15:17:44 +00:00
Douwe Maan
771bf9527f Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison 2017-12-22 18:07:15 +01:00
Douwe Maan
e4eba908cd Allow commenting on individual commits inside an MR 2017-12-07 09:01:19 -05:00
Felipe Artur
b54203f0ad Commenting on image diffs 2017-10-07 04:25:17 +00:00
Douwe Maan
0bf339f0ed Address review 2017-05-24 10:10:10 -05:00
Douwe Maan
f8fabfcc6f Allow commenting on older versions of the diff and comparisons between diff versions 2017-05-03 14:47:21 -05:00
Robert Speicher
58cd4c48e6 Fix NUMBER_OF_TRUNCATED_DIFF_LINES re-definition error 2017-04-12 13:59:35 -04:00
Douwe Maan
1817f877e1 Some code tweaks 2017-04-08 14:58:08 -05:00
Douwe Maan
c319f21141
Address review comments 2017-04-05 17:44:14 +01:00
Douwe Maan
2058e71e63
Extract commonalities between DiffDiscussion and LegacyDiffDiscussion 2017-04-05 17:44:14 +01:00