Commit graph

16 commits

Author SHA1 Message Date
Stan Hu
39f252254b Make sure there's only one slash as path separator
In Ruby 2.4, `URI.join("http://test//", "a").to_s` will
remove the double slash, however it's not the case in
Ruby 2.5. Using chomp should work better for the intention,
as we're not trying to allow things like ../ or / paths
resolution.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53180
2018-11-09 15:36:45 -08:00
gfyoung
1993a4449a Enable frozen string for app/helpers/**/*.rb
Partially addresses #47424.
2018-09-06 17:33:46 -07:00
Stan Hu
f2005125df Use slugs for default project path and sanitize names before import
Users importing from Bitbucket Cloud, Bitbucket Server, or GitHub
often complained about getting failed imports due to 422 errors.
This change ensures that project names are imported with names that
are guaranteed to pass the regular expression validation.

Part of #50021
2018-08-24 10:29:14 -07:00
Rubén Dávila
afe2c15e6b Fix provider server URL used when listing repos to import
Also use Gitlab::Auth::OAuth::Provider.config_for to access OmniAuth config
2018-03-12 16:01:43 -05:00
Rubén Dávila
d179f002d9 CE backport for creating CI/CD projects from GitHub 2018-03-07 10:58:50 -05:00
Robert Speicher
2e87923dcb Merge branch 'ce-3839-ci-cd-only-projects-fe' into 'master'
Create CI/CD-only projects by URL -- CE backport

See merge request gitlab-org/gitlab-ce!17342
2018-03-05 22:43:27 +00:00
Eric Eastwood
32d121343d CI/CD-only projects FE
See https://gitlab.com/gitlab-org/gitlab-ee/issues/3839

Conflicts:
	app/assets/javascripts/projects/project_new.js
	app/views/shared/_import_form.html.haml
	ee/app/controllers/ee/projects_controller.rb
	ee/spec/features/projects/new_project_spec.rb
	locale/gitlab.pot
2018-03-05 13:26:34 -06:00
Dmitriy Zaporozhets
86df5c6793
Replace deprecated path_with_namespace with full_path
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2018-03-05 15:41:54 +02:00
Robert Speicher
260c8da060 Whitelist or fix additional Gitlab/PublicSend cop violations
An upcoming update to rubocop-gitlab-security added additional
violations.
2017-08-14 12:14:11 -04:00
Jacob Schatz
c5a9d73ad8 Merge branch 'fix-links-target-blank' into 'security'
Adds rel="noopener noreferrer" to all links with target="_blank"

See merge request !2071
2017-03-20 18:51:36 -07:00
Rémy Coutable
20aff5cd2b Reduce duplication for GitHubish import status view
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-12-19 17:35:51 +01:00
Rémy Coutable
99ddd1dcbe Modify GithubImport to support Gitea
The reason is that Gitea plan to be GitHub-compatible so it makes sense
to just modify GitHubImport a bit for now, and hopefully we can change
it to GitHubishImport once Gitea is 100%-compatible.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-12-19 17:35:51 +01:00
Rémy Coutable
103114e3d7 Rename Gogs to Gitea, DRY the controller and improve views
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-12-19 17:35:51 +01:00
Kim "BKC" Carlbäcker
5d4531db25 Gogs Importer 2016-12-19 17:35:51 +01:00
Douglas Barbosa Alexandre
325de662ce Don't create groups for unallowed users when importing projects 2016-08-31 12:55:45 -03:00
Douglas Barbosa Alexandre
835acf22d4 Fix GitHub project's link on import page when provider has a custom URL 2016-04-19 13:21:30 -03:00