Commit graph

16 commits

Author SHA1 Message Date
tiagonbotelho
1d268a89de adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
Robert Speicher
97c4a1dcea Refactor Issues::BulkUpdateService spec
- Create fewer Issue objects; 2 is as good as 5 for these cases. This
  gives us a nice little speed improvement.
- Don't `describe` Symbols.
- Simplify object creation.
- Lessen "mystery guest" antipattern
2016-07-20 17:59:34 -06:00
Cairo Noleto
36dc4a5ce7 Allow bulk (un)subscription from issues in issue index
fixies #19747
2016-07-14 19:36:19 -03:00
Alfredo Sumaran
7df4a3c53a Fix spec 2016-06-03 17:14:23 -05:00
Sean McGivern
165d799fb3 Allow bulk-updating to remove all labels
Instead of passing `remove_label_ids`, just pass an empty array for
`label_ids` (and don't pass `add_label_ids` or `remove_label_ids`).
2016-06-03 17:14:23 -05:00
Alfredo Sumaran
d78fd6df0c Update CHANGELOG 2016-06-03 17:14:23 -05:00
Sean McGivern
0fcf6e1094 Tidy up BulkUpdateService specs
1. Don't use instance variables, use `let` instead.
2. Add descriptions for all specs.
3. Share variables where possible.
4. Give labels more vivid names than 1, 2, and 3.
5. Remove deprecation warnings by passing issue IDs as '1,2,3' instead
   of an array, as that's how they're passed by the front-end. (The
   deprecation warning is for passing a nested array, which is what
   happens if an actual array is passed, as:
     `[1, 2, 3].split(',') == [[1, 2, 3]]`
2016-06-03 17:14:23 -05:00
Sean McGivern
ac40843c94 fixup! WIP: allow adding and removing labels in bulk 2016-06-03 17:11:41 -05:00
Rémy Coutable
34007aa0dc
Fix deprecation warnings in spec/services/issues/bulk_update_service_spec.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-02 18:25:44 +02:00
Grzegorz Bizon
0c6f04427b Enable Performance/TimesMap Rubocop cop
Use Array.new with a block instead of `.times.collect` / `.times.map`.

See #17478
2016-05-30 14:21:26 +02:00
Grzegorz Bizon
8df63d1513 Update specs to accomodate issuable assign changes 2016-04-22 08:00:57 +02:00
Douwe Maan
a2cfb44157 Tag service specs 2015-12-09 11:55:49 +01:00
Robert Speicher
15a05be70d Fix Style/Blocks cop violations 2015-06-22 16:00:54 -04:00
Douwe Maan
b673d87227 Send notifications and leave system comments when bulk updating issues. 2015-03-06 15:01:13 +01:00
Robert Speicher
e53dd7526f Allow mass-unassigning of issues
Fixes #867

[ci skip]
2015-02-25 23:57:23 -05:00
Robert Speicher
8490a8ab2a Rename bulk_update_context_spec to bulk_update_service_spec 2015-02-25 23:55:53 -05:00
Renamed from spec/services/issues/bulk_update_context_spec.rb (Browse further)