Commit Graph

15 Commits

Author SHA1 Message Date
GitLab Bot c59765a50a Add latest changes from gitlab-org/gitlab@master 2020-06-24 18:09:03 +00:00
GitLab Bot c4c1fc5fe7 Add latest changes from gitlab-org/gitlab@master 2020-05-15 15:08:04 +00:00
Luke Duncalfe 37b17fa61a Add service classes for mutating AwardEmoji
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
2019-08-21 11:39:41 +12:00
Thong Kuah a2cfc150ce Add # frozen_string_literal to spec/models
Adds `# frozen_string_literal: true` to spec/models ruby files
2019-04-01 14:37:54 +13:00
Toon Claes 8ae9b24851 Don't care about order when getting awarded issues
Fixing failing master:
https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/116776474
2018-11-15 20:51:43 +13:00
Thong Kuah 03dba01273 Revert "Extract code into IssueBoardEntity"
This reverts commit 8c126525fa.
2018-11-09 13:19:48 +13:00
Toon Claes ef68b8737f Don't care about order when getting awarded issues
Fixing failing master:
https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/116776474
2018-11-06 07:02:01 +01:00
Heinrich Lee Yu 8df7e6021b Fix tests 2018-11-01 07:45:36 +08:00
Chantal Rollison 009c4f7fb8 Allows author to vote on their own issue 2018-08-24 10:13:41 +00:00
Bob Van Landuyt 04c7d0d555 Prevent awarding emoji when a project is archived
This prevents performing the requests, and disables all emoji reaction buttons
2018-04-11 10:51:43 +02:00
Hiroyuki Sato 7187395ef1 Add filter by my reaction 2017-08-30 07:48:55 +00:00
Sean McGivern 5069682d8e Enable RSpec/FilePath cop
- Ignore JS fixtures
- Ignore qa directory
- Rewrite concern specs to put concern name first
2017-04-26 12:50:32 +01:00
Andrew Smith e71df3cdd2
Order award tooltips by their created_at date 2016-09-01 08:40:10 +10:00
Grzegorz Bizon b75945e9e4 Fix rubocop offense in awardable specs 2016-06-06 07:42:12 +02:00
Zeger-Jan van de Weg dccf8a9fc8 Add tests on Awardables and Award Emoji 2016-05-10 12:03:13 +02:00