Commit graph

27 commits

Author SHA1 Message Date
GitLab Bot
3795b229ab Add latest changes from gitlab-org/gitlab@master 2020-05-01 00:09:59 +00:00
George Koltsov
13adfb3e7a Add bitbucket_server/client_spec.rb spec 2019-08-12 11:16:17 +01:00
Thong Kuah
f540ffcef6 Add frozen_string_literal to spec/lib (part 1)
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-07-26 13:25:07 +12:00
Stan Hu
a0856cf7b9 Fix BitbucketServer::Client failing with Webmock 3.5.1
Webmock 3.1.0 changed the behavior to return `nil` for the body if an
HTTP 204 No Content response were received
(b837e64278).

Update the Bitbucket Server connection to ignore these No Content
response codes.
2019-02-16 15:30:02 -08:00
Stan Hu
660dcd5b7c Fix Bitbucket Server importer error handling
The importer would display a 500 error page if you attempted to import
using a non-existent DNS entry. This commit rescues known network issues
and consolidates them into
BitbucketServer::Connection::ConnectionError`.  The previous error
handling in the paginator doesn't work because it returns a lazy
collection.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56154
2019-01-12 22:14:08 -08:00
Stan Hu
a06b7a7d5d Fix Bitbucket Server import only including first 25 pull requests
The change to paginate repos in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22825 caused the
paginator to stop after 25 pull requests because the limit was set to 25
if none was defined. To fix this, we should only stop if the limit has
actually been set and use the limit parameter to determine the maximum
number of items to process per page.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55914
2019-01-06 21:13:00 -08:00
Stan Hu
5b6d5301d9 Paginate Bitbucket Server importer projects
To prevent delays in loading the page and reduce memory usage, limit the
number of projects shown at 25 per page.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/50021
2018-11-07 11:37:46 -08:00
Stan Hu
d2fd6d2351 Deal with subpaths and trailing slashes properly 2018-07-31 21:14:36 -07:00
Stan Hu
710d82104d Track parental relationships in comments 2018-07-31 11:12:10 -07:00
Stan Hu
3cda8c93d8 Fix merge request SHA 2018-07-30 23:37:54 -07:00
Stan Hu
ae6b48d20f Fix failing spec in spec/lib/bitbucket_server/client_spec.rb 2018-07-28 17:09:10 -07:00
Stan Hu
57d1b60f61 Handle invalid JSON from server 2018-07-27 14:29:05 -07:00
Stan Hu
450030e902 Add Accept header for JSON 2018-07-27 12:58:17 -07:00
Stan Hu
3f715bb438 Consolidate server errors and add specs 2018-07-26 23:05:22 -07:00
Stan Hu
079b490ad2 Fix failing specs 2018-07-26 21:55:23 -07:00
Stan Hu
7ee9c3c436 Use project key instead of project name for imports 2018-07-26 15:45:38 -07:00
Stan Hu
930b5e7a5b Add spec for pull request comments and add comments 2018-07-25 21:39:52 -07:00
Stan Hu
d09034acca Add pull request spec 2018-07-25 20:54:15 -07:00
Stan Hu
ae7574f952 Add specs for activity and comments 2018-07-25 20:51:12 -07:00
Stan Hu
6762aa0d45 Fix tense of example description 2018-07-25 05:25:03 -07:00
Stan Hu
7c1aaf68f8 Add spec for BitbucketServer::Representation::Repo 2018-07-20 21:47:00 -07:00
Stan Hu
c73db33f1e Add spec for pages 2018-07-19 23:19:20 -07:00
Stan Hu
af94867733 Add spec for paginator 2018-07-19 23:10:50 -07:00
Stan Hu
9d59616b95 Fix URL for deleting branches 2018-07-18 23:15:24 -07:00
Stan Hu
c793252e8b Add support for deleting branches via the Bitbucket Server API 2018-07-13 15:39:24 -07:00
Stan Hu
ec4109d413 Make Connection#post consistent with Connection#get and add specs 2018-07-12 23:17:05 -07:00
Stan Hu
15220291ae Add spec for BitbucketServer::Connection 2018-07-12 22:33:36 -07:00