Commit Graph

8 Commits

Author SHA1 Message Date
Douwe Maan 52967b107b
Merge branch 'jej/mattermost-notification-confidentiality-10-6' into 'security-10-6'
[10.6] Prevent notes on confidential issues from being sent to chat

See merge request gitlab/gitlabhq!2366
# Conflicts:
#	app/helpers/services_helper.rb
2018-04-05 08:41:56 +02:00
Sean McGivern 1afddb7063 Prevent cluster migration spec from interfering with later specs
If a later spec tries to set a field that is added to any of these models by a
later migration than the GCP clusters migration, it will fail because the
model's columns are cached.

We should always refer to models in migration specs by either their class in the
migration, or the table directly, using the `table` helper.
2018-01-05 17:44:38 +00:00
Bob Van Landuyt 5ac98f9315 Create models directly in migration specs
Instead of using the factories. Since the factories might be using
columns that aren't available in the schema at version the particular
spec is running in.
2017-12-12 09:44:21 +01:00
Matija Čupić f1357a1e15
Remove references of project.cluster from specs 2017-12-04 17:02:18 +01:00
Shinya Maeda 8fb7e87806 Move migration file to post-migration. Use EachBatch. batch_size 1 2017-11-04 03:22:04 +09:00
Shinya Maeda 8d8a860fbb Fix MigrateGcpClustersToNewClustersArchitectures. Improve spec 2017-11-03 21:16:34 +09:00
Shinya Maeda b78d8a748d Fix spec failure. MySQL does not bite true 2017-11-03 19:05:42 +09:00
Shinya Maeda 0c417ef043 Improve migration file. Add migration spec. Reorder columns of the table. 2017-11-01 21:28:47 +09:00