a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
b45567c5b3
Fix failing spec
2017-06-07 07:01:38 -05:00
657bc805a4
Add json support to group members leave action in controller
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-06-06 13:35:22 +03:00
d211011698
Make access request specs explicitly enable or disable access requests as required
2016-11-11 15:45:47 +00:00
1eba14ae2e
Refactor create member tests from group_members_controller_spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-24 13:14:00 +03:00
036fac06d1
Gracefully handle adding of no users to projects and groups
...
- Disable {project, group} members submit button if no users
If no users are selected, the submit button should be disabled.
- Alert user when no users were added to {project, group}.
When no users were selected for adding, an alert message is
flashed that no users were added.
- Also, this commit adds a feedback when users were actually added to a
project, in symmetry with how group members are handled.
Closes #22967 , #23270 .
2016-10-24 13:14:00 +03:00
fa075771a6
Refactor group_members_controller_spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-19 14:13:44 +03:00
c8b1311934
Fix a few things after the initial improvment to Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
5dcdf1d51b
Ensure Members::ApproveAccessRequestService can fin a requester by ID
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-09-22 15:50:48 +02:00
bd78f5733c
Exclude requesters from Project#members, Group#members and User#members
...
And create new Project#requesters, Group#requesters scopes.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-01 17:44:46 +02:00
abca19da8b
Use HTTP matchers if possible
2016-06-27 20:10:42 +02:00
909a0ff3ac
Fix and remove duplicate specs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-20 12:36:59 +02:00
724f986fb2
Redirect to the member's source on request withdrawal
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
515205d3c1
UI and copywriting improvements
...
+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:18:14 +02:00
d71fbe0dbd
Factorize #request_access and #approve_access_request into a new AccessRequestActions controller concern
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:07:26 +02:00
d26f81239a
Add request access for groups
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 13:07:26 +02:00
09c8cf9de6
Remove group members check
2016-04-18 11:12:28 -03:00
e8a77c0aee
Fix code
2016-04-18 11:12:27 -03:00
668d6ffa43
Add specs and fix code
2016-04-18 11:12:27 -03:00
Robert Speicher