Keifer Furzland
7e113b6824
Remove superfluous type defs in specs
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Sean McGivern
88df076fae
Merge branch '33359-pers-snippet-files-location' into 'security-9-3'
...
Use uploads/system directory for personal snippets
See merge request !2123
2017-07-19 22:28:27 -05:00
Robert Speicher
eef068754a
Merge branch 'master' into rs-sign_in
2017-07-06 12:43:51 -04:00
Rémy Coutable
d9a5d92140
Merge branch '23036-replace-snippets-spinach' into 'master'
...
Replace 'snippets/snippets.feature' spinach with rspec
See merge request !12385
2017-07-05 15:04:05 +00:00
Alexander Randa
9651521ea7
Replace 'snippets/snippets.feature' spinach with rspec
2017-07-05 15:29:01 +03:00
Robert Speicher
e939bf7be1
Change gitlab_sign_in to sign_in where possible
2017-06-29 12:18:23 -04:00
Luke "Jared" Bennett
e2ea3e5c84
Resolve "Unable to access edit comment from dropdown menu in certain screen sizes"
2017-06-27 15:41:56 +00:00
Grzegorz Bizon
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
Robert Speicher
45fb1f9542
Change login_as
uses to gitlab_sign_in
2017-06-19 18:59:01 -05:00
Eric Eastwood
e51078ecfc
Disable autocomplete on snippets comments
...
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/33594
Was supposedly fixed in MR for
https://gitlab.com/gitlab-org/gitlab-ce/issues/32086 but seeing this pop
up again
2017-06-19 13:42:12 -05:00
Luke "Jared" Bennett
32cac59727
Added more actions and report as abuse to all notes
2017-06-07 18:33:50 +00:00
Jarka Kadlecova
2e311d9d1a
Support uploads for newly created personal snippets
2017-06-07 07:52:41 +02:00
Jarka Kadlecova
4464c22d6d
Support descriptions for snippets
2017-05-31 07:17:03 +02:00
Oswaldo Ferreira
2338785ec9
Use wait_for_requests to wait all JS request
2017-05-22 20:39:49 -03:00
Douwe Maan
ad309f5d11
Merge branch 'snippets-finder-visibility' into 'security'
...
Refactor snippets finder & dont return internal snippets for external users
See merge request !2094
2017-05-10 16:48:18 +02:00
Sean McGivern
d9ec830a83
Merge branch 'snippets_visibility' into 'security'
...
Fix snippets visibility for show action - external users can not see internal snippets
See merge request !2087
2017-05-10 16:44:20 +02:00
Luke "Jared" Bennett
4c25701dc6
Just assert the existence of the timeago element
2017-05-08 11:06:09 +00:00
Luke "Jared" Bennett
17fc18ec2c
Check for all possible timeago strings that can be rendered in a few minutes. We cannot rely on 'less than a minute ago'
2017-05-08 09:09:08 +00:00
Jarka Kadlecova
e4f7b87ddb
Support comments for personal snippets
2017-05-05 15:45:49 +02:00
Sean McGivern
c5dee301f8
Merge branch 'dm-snippet-download-button' into 'master'
...
Add download button to project snippets
See merge request !11004
2017-05-02 15:25:26 +00:00
Jarka Kadlecova
8c3a03c1b9
Display comments for personal snippets
2017-05-02 13:07:53 +02:00
Douwe Maan
2b3fc5e624
Add download button to project snippets
2017-04-30 17:52:49 -05:00
Douwe Maan
60ebd101d0
Use blob viewers for snippets
2017-04-30 11:21:20 -05:00
Rémy Coutable
01e95b065e
Merge branch 'move-user-snippets-spinach-test-to-rspec' into 'master'
...
Move 'User Snippets' Spinach feature to Rspec
See merge request !8574
2017-02-09 17:47:58 +00:00
the-undefined
256a55d47b
Move 'User Snippets' Spinach feature to Rspec
...
This commit moves the `snippets/user.feature` Spinach test to a
Rspec feature, as part of deprecating the Spinach test suite.
- Remove Spinach discover snippets feature and steps
- Add Rspec feature test
2017-01-16 06:52:18 +00:00
blackst0ne
ad977e8bb2
Allow to use + symbol in filenames
2017-01-15 19:48:35 +11:00
Rémy Coutable
beedd40ef7
Ensure user is authenticated to create a new snippet
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-11-28 16:57:49 +01:00
Dmitriy Zaporozhets
e38acad435
Merge branch 'move-snippet-discover-spinach-test-to-rspec' into 'master'
...
Move 'Explore Snippets' Spinach feature to Rspec
## What does this MR do?
It moves the `features/snippets/discover.feature` Spinach test to a Rspec feature.
## Are there points in the code the reviewer needs to double check?
The original feature was called 'Discover Snippets', but the UI no longer reflects this wording. The new Rspec feature is called 'Explore Snippets' to reflect UI/Controller/View naming in use.
## Why was this MR needed?
As part of deprecating the Spinach test suite.
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [-] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html ) added
- [-] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md )
- [-] API support added
- Tests
- [x] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html )
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides )
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits )
## What are the relevant issue numbers?
#23036
See merge request !7349
2016-11-16 14:15:41 +00:00
the-undefined
dbf5c8abfe
Move 'Search Snippets' Spinach feature to Rspec
...
This commit moves the `search_snippets.feature` Spinach test to a
Rspec feature, as part of deprecating the Spinach test suite.
- Remove Spinach discover snippets feature and steps
- Remove unused `SharedSearch` module
- Add Rspec feature scenarios
2016-11-16 06:52:43 +00:00
the-undefined
903431e889
Move 'Explore Snippets' Spinach feature to Rspec
...
This commit moves the `snippets/discover.feature` Spinach test to a
Rspec feature, as part of deprecating the Spinach test suite.
The original feature was called 'Discover Snippets', but the UI no
longer reflects this wording. The new Rspec feature is called
'Explore Snippets' to reflect UI/Controller/View naming in use.
- Remove Spinach discover snippets feature and steps
- Add Rspec feature test
2016-11-08 06:37:02 +00:00
the-undefined
27528d4490
Move spinach public snippet feature to rspec spec
...
- Add rspec feature for public snippets
- Remove spinach test for public snippets
2016-11-04 06:58:40 +00:00