Commit graph

22 commits

Author SHA1 Message Date
Jarka Kadlecova
f7c18ca314 Support uploads for groups 2017-12-07 12:27:52 +01:00
Tomasz Maczukin
97f966c445
Introduce :read_namespace access policy for namespace and group 2017-11-23 17:44:05 +01:00
Felipe Artur
5bfb6357ef Allow DEVELOPER role to admin milestones 2017-09-18 17:15:38 -03:00
Ruben Davila
62bb6235c2 Make Members with Owner and Master roles always able to create subgroups 2017-09-07 13:47:58 -05:00
Michael Kozono
95f4dd4f15 Optimize policy rule 2017-09-07 09:42:15 -07:00
Michael Kozono
1feeea9c6a Refer to “Share with group lock” consistently 2017-09-06 12:07:21 -07:00
Michael Kozono
5404dbb49d Fix ability when Share lock is off 2017-09-06 12:07:21 -07:00
Michael Kozono
a4b564b620 Refactor based on code review 2017-09-06 12:07:21 -07:00
Michael Kozono
c7e17abd26 Fix “Share lock” policy for deeply nested groups 2017-09-06 12:07:20 -07:00
Michael Kozono
6c57734677 Enforce share_with_group_lock rules
…in Groups::UpdateService instead of only in the browser.
2017-09-06 12:07:20 -07:00
Tiago Botelho
5bc9dedf40 Improves subgroup creation permissions 2017-08-21 15:40:22 +01:00
Shinya Maeda
5b0954759c Basic BE change
Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Implement CURD

Rename codes related to VariableGroup and VariableProject FE part

Remove unneccesary changes

Make Fe code up-to-date

Add protected flag to migration file

Protected group variables essential package

Update schema

Improve doc

Fix logic and spec for models

Fix logic and spec for controllers

 Fix logic and spec for views(pre feature)

Add feature spec

Fixed bugs. placeholder. reveal button. doc.

Add changelog

Remove unnecessary comment

godfat nice catches

Improve secret_variables_for arctecture

Fix spec

Fix StaticAnlysys & path_regex spec

Revert "Improve secret_variables_for arctecture"

This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.

Use ayufan suggestion for secret_variables_for

Use find instead of find_by

Fix spec message for variable is invalid

Fix spec remove variable.group_id = group.id

godffat spec nitpicks

Use include Gitlab::Routing.url_helpers for presenter spec
2017-07-07 15:33:17 +09:00
http://jneen.net/
37c401433b convert all the policies to DeclarativePolicy 2017-06-27 12:44:37 -07:00
Sean McGivern
5db229fb45 Allow group reporters to manage group labels
Previously, only group masters could do this. However, project reporters can
manage project labels, so there doesn't seem to be any need to restrict group
labels further.

Also, save a query or two by getting a single GroupMember object to find out if
the user is a master or not.
2017-06-05 11:58:53 +01:00
Rémy Coutable
59f81b4ff8 Merge branch 'siemens/gitlab-ce-fix/subgroup-hide-button' into 'master'
Hide new subgroup button if user has no permission to create one

Closes #30139

See merge request !10627
2017-04-12 09:26:16 +00:00
Dmitriy Zaporozhets
525ea06687
Move permission to create subgroup into GroupPolicy
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-11 19:36:56 +03:00
Jacopo
b996a82ff4 ProjectsFinder should handle more options
Extended ProjectFinder in order to handle the following options:
 - current_user - which user use
 - project_ids_relation: int[] - project ids to use
 - params:
   -  trending: boolean
   -  non_public: boolean
   -  starred: boolean
   -  sort: string
   -  visibility_level: int
   -  tags: string[]
   -  personal: boolean
   -  search: string
   -  non_archived: boolean

GroupProjectsFinder now inherits from ProjectsFinder.
Changed the code in order to use the new available options.
2017-04-06 07:11:37 +02:00
Drew Blessing
bd5474937c Remove now unnecessary additional_rules! method from GroupPolicy
The intention was for this to be used to override group policy in
EE. This led to all sort of strange problems in practice - for
example, https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1025
needed to override `owner` permissions, but `additional_rules!`
passed `master` only. The better solution is to use an EE
module to override the policy. Removing this now defunct method.
2017-02-28 13:59:30 -06:00
Dmitriy Zaporozhets
7b4b3d5f26 Include group parents into read access for project and group
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-12-26 10:57:11 +02:00
Douglas Barbosa Alexandre
8c639ac23c Backport hooks on group policies for the EE-specific implementation 2016-12-13 11:51:09 -02:00
Douglas Barbosa Alexandre
52e0c3b565 Add CRUD for Group Labels 2016-10-19 14:57:15 -02:00
http://jneen.net/
ccfa032ebc port groups 2016-08-30 11:39:22 -07:00