Commit graph

19 commits

Author SHA1 Message Date
Timothy Andrew
7ee0898a9e Implement @DouweM's feedback.
- Extract a duplicated `redirect_to`
- Fix a typo: "token", not "certificate"
- Have the "Expires at" datepicker be attached to a text field, not inline
- Have both private tokens and personal access tokens verified in a
  single "authenticate_from_private_token" method, both in the
  application and API. Move relevant logic to
  `User#find_by_personal_access_token`
- Remove unnecessary constants relating to API auth. We don't need a
  separate constant for personal access tokens since the param is the
  same as for private tokens.
2016-06-16 08:24:13 +05:30
Timothy Andrew
d0bcba1105 Merge remote-tracking branch 'origin/master' into 2979-personal-access-tokens 2016-06-14 09:06:53 +05:30
Annabel Dunstone
3e28d04cce Fix preferences_spec test 2016-06-10 15:08:13 -05:00
Timothy Andrew
e18a08fd89 Implement second round of comments from @jschatz1.
- Just use a link for the clipboard button. Having a non-clickable
  container (that looks like a button) is confusing.
- Use `text-danger` for the "you won't be able to access it again" message.
- Highlight the created token so people know to look there.
2016-06-10 10:30:49 +05:30
Timothy Andrew
1f5ecf916e Implement @jschatz1's comments.
- No hardcoded colors in any SCSS file except `variables.scss`
- Don't allow choosing a date in the past
- Use the same table as in the "Applications" tab
- The button should say "Create Personal Access Token"
- Float the revoke button to the right of the table cell
- Change the revocation message to be more explicit.
- Date shouldn't look selected on page load
- Don't use a panel for the created token
    - Use a normal flash for "Your new personal access token has been created"
    - Show the input (with the token) below it full width.
    - Put the "Make sure you save it - you won't be able to access it again." message near the input
- Have the created token's input highlight all on single click
2016-06-09 14:08:49 +05:30
Timothy Andrew
3adf125a15 Add tests for errors while creating/revoking personal access tokens. 2016-06-03 10:00:03 +05:30
Timothy Andrew
a1295d8ebe Don't use natve['innerHTML'] in the feature spec.
- The `have_text` matcher works fine.
2016-06-03 08:58:15 +05:30
Timothy Andrew
4d50d8a6e3 Only show a personal access token right after its creation. 2016-06-02 11:06:38 +05:30
Timothy Andrew
bafbf22c6a Address @DouweM's feedback on !3749.
- Use `TokenAuthenticatable` to generate the personal access token
- Remove a check for `authenticity_token` in application controller;
  this should've been `authentication_token`, maybe, and doesn't make
  any sense now.
- Have the datepicker appear inline
2016-04-28 22:28:36 +05:30
Timothy Andrew
25aefde62b Add feature specs for personal access token management. 2016-04-28 22:28:36 +05:30
Stan Hu
c7e384aab2 Add spec for deletion of authorized OAuth2 application
Closes #14370

Move gon function into its own helper
2016-04-14 07:24:58 -07:00
Douwe Maan
f87f6480b2 Use new routing helper 2015-09-08 17:53:16 +01:00
Robert Speicher
4b4351a18c Add feature tag to feature specs
Not to be confused with the RSpec `type: :feature` tag, this tag is used
by the `spec:feature` Rake task for filtering/grouping specs.
2015-07-06 22:39:55 -04:00
Robert Speicher
afec5efc7d Fix features syntax 2015-06-22 12:13:45 +02:00
Robert Speicher
b00f447db4 Add allowing_for_delay helper method for feature specs 2015-06-14 20:33:29 -04:00
Robert Speicher
bf9dd4327e Add feature specs for default dashboard preference 2015-06-13 17:59:12 -04:00
Robert Speicher
0e21436aaf Simplify the javascript behavior for Preference updating 2015-06-13 17:58:17 -04:00
Robert Speicher
844d72716e Add Gitlab::Themes module; remove Gitlab::Theme
Now we can simply loop through all themes, among other things.

This also removes the `dark_theme` / `light_theme` classes and the
`theme_type` helper, since they weren't used anywhere.
2015-06-13 17:58:16 -04:00
Robert Speicher
0c0c31ff34 Move the "Design" templates and logic to Preferences 2015-06-13 17:58:16 -04:00