Commit Graph

30 Commits

Author SHA1 Message Date
Bryce Johnson 728be6af7c Make setSidebarHeight more efficient with SidebarHeightManager. 2017-06-30 10:03:50 -04:00
Eric Eastwood 291309f431 Fix scroll flicker
See https://gitlab.com/gitlab-org/gitlab-ce/issues/34407

 - Revert https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12399
 - Update https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12299
   throttle/debounce to happen immediately and cleanup
2017-06-28 11:33:27 -05:00
Annabel Dunstone Gray c12172ee33 Remove layout nav from scroll calculation 2017-06-22 16:34:52 -05:00
Tim Zallmann 278bf413bf Fixes scrolling + improves Performance through assigning found $ elements to variables 2017-06-20 16:45:26 +02:00
Mike Greiling 4c25670656 remove bind polyfill from right_sidebar.js 2017-05-08 17:40:19 -05:00
Filipa Lacerda 024d8be0f8 Merge branch '30063-builds-sidebar-stutter' into 'master'
Add subnav height to sidebar scroll calculation

Closes #30063

See merge request !10262
2017-03-30 13:00:33 +00:00
Annabel Dunstone Gray 5de7eac67d Add subnav height to sidebar scroll calculation 2017-03-28 10:08:16 -05:00
Phil Hughes 89d1a1c097 Added specs for collapsed sidebar 2017-03-27 16:02:20 +01:00
Phil Hughes 96f5188098 Updated todos sidebar icon
Refactored slightly so that the same logic is shared between both the
expanded & the collapsed.
2017-03-24 16:17:38 +00:00
dimitrieh 9acfa6351f adds todo functionality to closed issuable sidebar and changes todo bell icon to check-square 2017-03-24 16:04:57 +01:00
Annabel Dunstone Gray bb1ed93601 Switch to check scrollTop of window 2017-03-23 15:16:31 -06:00
Mike Greiling 5f7c0bd7b7 remove Cookies class from global space 2017-03-22 03:07:27 -05:00
Mike Greiling 0f31c5a92b replace implicit this == window with explicit binding 2017-02-17 16:58:32 -06:00
Annabel Dunstone Gray 7203826b54 Cache js selectors; fix css 2017-02-16 13:19:01 -06:00
Annabel Dunstone Gray 06239e13e5 Move necessary sidebar code to right_sidebar.js; delete sidebar.js 2017-02-15 17:16:13 -06:00
Mike Greiling 04eff5fdb0 resolve all x-spacing and no-spaced-x eslint violations 2017-01-18 17:18:40 -06:00
Mike Greiling ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling e7b5945c59 resolve all semi and no-extra-semi eslint violations 2017-01-18 17:15:27 -06:00
Mike Greiling 8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
Luke "Jared" Bennett 7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
Fatih Acet f879319840 Merge branch 'add-todo-toggle-event' into 'master'
Add todo toggle event

## What does this MR do?
Adds a custom jQuery event `todo:toggle` to detect when a new todo is added so that the respective todo counters (header navigation and sidebar) can update as needed

## Are there points in the code the reviewer needs to double check?

*  I wasn't sure whether each `spec` should be modularized based on the html templates or whether they should be separated based on function. There are some crossovers between the `dashboard_spec` and the `header_spec`.
* The naming conventions for `sidebar` and `right_sidebar` were a little confusing since they were named the opposite in their `specs`. I made a few assumptions and named a few files based on what I thought they should be named. I'd be happy to change it to something else though 😄  

## Why was this MR needed?
This resolves an existing issue where the todo count on the sidebar would not update (until refresh) and refactors the existing methods that are used to update the todo counters (header navigation and sidebar)

## What are the relevant issue numbers?
Closes #20140

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5724
2016-10-27 13:28:40 +00:00
Clement Ho f610f69ab9 Add todo toggle event 2016-10-26 16:28:56 -05:00
Fatih Acet dd5e46ab69 Merge branch 'eslint' into 'master'
Add ESLint

## What does this MR do?

- create `package.json`
- add ESLint dependencies to `package.json`
- add JavaScript linting to CI
- add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`)

## Are there points in the code the reviewer needs to double check?

Probably not.

## Why was this MR needed?

My hovercraft was full of eels.

## What are the relevant issue numbers?

- https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658


See merge request !5445
2016-10-26 16:31:08 +00:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Phil Hughes a2eff1a8e5 Merge branch 'master' into issue-board-sidebar 2016-10-26 08:47:09 +01:00
Mike Greiling f8520f5d09 remove manual Cookie.set "path" option in favor of global setting 2016-10-24 18:09:00 -05:00
Mike Greiling 67d2b2acb3 replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
Phil Hughes 6cece3f49e Show clicked issue data in the sidebar 2016-10-07 09:14:33 +01:00
Mike Greiling 33694a5a64 use gitlab global root url as canonical base url for all javascript set cookies (closes #20435) 2016-08-24 22:11:28 -05:00
Fatih Acet aaa9509d12 ES6ify all the things! 2016-07-24 23:45:11 +03:00