Commit graph

19 commits

Author SHA1 Message Date
Oswaldo Ferreira
6a5a5d0ec0 Remove border from issues, todos and MR pages 2017-01-27 20:20:19 -02:00
Berna Castro
1c749880e5 Refactor code when rendering a collection of issues 2017-01-27 20:20:17 -02:00
Berna Castro
4e2b9d703f Don't group projects on dashboard#issues 2017-01-27 20:20:16 -02:00
Sean McGivern
79b5bfc113 Save a query on issue and MR lists
`any?` on an AR relation performs a `SELECT COUNT`, which we don't need.

1. We are very likely to have issues or MRs, so the `SELECT COUNT` is
   often unnecessary.
2. Even where there are no items returned, the overhead of the
   `SELECT *` instead of `SELECT COUNT` is relatively small.

Calling `to_a` on the relation lets us use `Enumerable#any?`, which will
return immediately if there are objects returned.
2016-12-01 12:24:55 +00:00
Luke "Jared" Bennett
a08fba63be
Added empty state svg and set up blank conditional
Added new spec step

Added empty state to dashboard

Split empty and filtered empty states

Moved empty_state icons into their own folder and DRY up empty state html

Fixed failing spec

Added to groups page

Review changes
2016-11-18 03:57:36 +00:00
Sean McGivern
1cc0209a80 Fix style
- `reorder(nil)` is better than `reorder('')`
- Only use ASCII in comments
2016-06-06 11:59:49 -05:00
Sean McGivern
b28237b4d2 Don't try to count a relation with aliases
Work around ActiveRecord count and column aliases issue as described at:
  <https://github.com/rails/rails/issues/15138#issuecomment-61325080>

AR doesn't promise that `#count` (which is called by `#any?`) will work
for relations using `#select`, which means we need a workaround instead.
2016-06-06 11:59:49 -05:00
Dmitriy Zaporozhets
2b5a6487ba Refactor styles for issues list
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-02-26 14:44:39 +01:00
Douwe Maan
b66694d236 Add "New X" link to dashboard/group milestone project-specific issue/MR panels 2015-12-02 14:00:54 +01:00
Vinnie Okada
76aad9b76e Upgrade to Rails 4.1.9
Make the following changes to deal with new behavior in Rails 4.1.2:

* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
Dmitriy Zaporozhets
5ba00d950b
Add old ui-box style to panels
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-05-30 23:43:53 +03:00
Dmitriy Zaporozhets
38ff5d1ab9
Replace ui-box title with panel-heading
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-05-29 18:43:21 +03:00
Dmitriy Zaporozhets
6dcbe1b43c
Replace ui-box with panel.panel-default
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-05-29 18:42:44 +03:00
Dmitriy Zaporozhets
32ecb02784
Refactor scss
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-02-20 13:51:22 +02:00
Dmitriy Zaporozhets
dac67ed65f
Use new ui-box classes
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2013-12-24 11:45:42 +02:00
Henry Smith
4b91ffca3e More specific empty state message wording
I've changed all the instances of "Nothing to show here" to specifically mention
the name of the entity of which there are none to show. This makes for a
slightly smoother reading experience.
2013-08-15 18:31:16 +01:00
Dmitriy Zaporozhets
a43a380394 Increase amount of search results for issues, mr, projects 2013-08-07 22:51:36 +03:00
Dmitriy Zaporozhets
27b7aeddfb More compact lists for dashboard issues, mr 2013-08-06 21:22:41 +03:00
Dmitriy Zaporozhets
512cd02335 Dashboard/Group issues and mr pages refactoring 2013-08-06 21:12:01 +03:00