Commit graph

4 commits

Author SHA1 Message Date
Douwe Maan
eacae00516 Enable Style/MultilineHashBraceLayout 2017-02-23 09:32:22 -06:00
Douwe Maan
b7d8df503c Enable Style/MutableConstant 2017-02-23 09:31:56 -06:00
Z.J. van de Weg
6ef6f9f205 Do not check for valid url for .gitlab-ci.yml
Until this commit, GitLab would check if the URL in your .gitlab-ci.yml
would be valid and adressable. However, this approach is rather limited.

To begin, the URL couldn't be http://example:$PORT/my-project, as the
PORT value would be interpolated after checking if the URL was valid,
which its not. Also this gem will limit the amount of protocols allowed.

This commit doesn't check, at all, if the URL is valid. This is now the
responsablilty of the user. In my opion this is right, as the user
ultimately benefits from a correct URL, but also, its impossible to
cover all cases.
2017-01-05 19:59:10 +01:00
Grzegorz Bizon
c701468390 Improve naming convention in ci configuration module 2016-11-14 10:31:45 +01:00
Renamed from lib/gitlab/ci/config/node/environment.rb (Browse further)