5 Commits

Author	SHA1	Message	Date
Nick Thomas	6ce21a9c17	Add a predicate to check for strong memoization	2019-09-10 13:45:21 +01:00
Rémy Coutable	6b39f55d3f	Add cache to the 'compile-assets' and 'gitlab:assets:compile' jobs ... Signed-off-by: Rémy Coutable <remy@rymai.me>	2019-02-05 14:04:54 +01:00
gfyoung	f93f8f569d	Enable even more frozen string for lib/gitlab ... Enables frozen string for the following: * lib/gitlab/patch/**/*.rb * lib/gitlab/popen/**/*.rb * lib/gitlab/profiler/**/*.rb * lib/gitlab/project_authorizations/**/*.rb * lib/gitlab/prometheus/**/*.rb * lib/gitlab/query_limiting/**/*.rb * lib/gitlab/quick_actions/**/*.rb * lib/gitlab/redis/**/*.rb * lib/gitlab/request_profiler/**/*.rb * lib/gitlab/search/**/*.rb * lib/gitlab/sherlock/**/*.rb * lib/gitlab/sidekiq_middleware/**/*.rb * lib/gitlab/slash_commands/**/*.rb * lib/gitlab/sql/**/*.rb * lib/gitlab/template/**/*.rb * lib/gitlab/testing/**/*.rb * lib/gitlab/utils/**/*.rb * lib/gitlab/webpack/**/*.rb Partially addresses gitlab-org/gitlab-ce#47424.	2018-11-19 18:24:22 -08:00
Zeger-Jan van de Weg	3ab026b7d6	Use memoization for commits on diffs ... The Gitaly CommitService is being hammered by n + 1 calls, mostly when finding commits. This leads to this gRPC being turned of on production: https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378 Hunting down where it came from, most of them were due to MergeRequest#show. To prove this, I set a script to request the MergeRequest#show page 50 times. The GDK was being scraped by Prometheus, where we have metrics on controller#action and their Gitaly calls performed. On both occations I've restarted the full GDK so all caches had to be rebuild. Current master, 806a68a81f, needed 435 requests After this commit, 154 requests	2017-12-12 16:28:26 +01:00
Lin Jen-Shin (godfat)	258bf3e187	Add Gitlab::Utils::StrongMemoize	2017-11-13 15:27:30 +00:00