Sean McGivern
|
4ef3e3491e
|
Add cop for has_many :through without disabled autoloading
Goldiloader is great, but has several issues with has_many :through relations:
* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18
Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
|
2018-04-09 12:47:04 +01:00 |
|
Douwe Maan
|
95ced3bb5f
|
Merge branch 'fj-15329-services-callbacks-ssrf' into 'security-10-6'
Server Side Request Forgery in Services and Web Hooks
See merge request gitlab/gitlabhq!2337
|
2018-03-21 14:39:21 +00:00 |
|
Lin Jen-Shin
|
4f00a05152
|
Introduce PredicateMemoization cop and fix offenses
with StrongMemoize
|
2018-01-12 17:54:55 +08:00 |
|
Rémy Coutable
|
a2d39b8010
|
Use gitlab-styles
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
2017-12-22 08:34:44 -06:00 |
|
Lin Jen-Shin
|
07d3d44775
|
Move ModuleWithInstanceVariables to Gitlab namespace
And use .rubocop.yml to exclude paths we don't care,
rather than using the cop itself to exclude.
|
2017-11-22 17:06:57 +08:00 |
|