Commit graph

6 commits

Author SHA1 Message Date
Rémy Coutable
aa0d8b4cba Merge branch 'frozen_string_spec_features' into 'master'
Add frozen_string_literal to spec/features

See merge request gitlab-org/gitlab-ce!31131
2019-07-29 08:29:43 +00:00
Thong Kuah
73e848850c Add frozen_string_literal to spec/features
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-07-26 13:23:30 +12:00
Heinrich Lee Yu
1ce5bcacdb Remove code related to object hierarchy in MySQL
These are not required because MySQL is not
supported anymore
2019-07-25 15:35:06 +08:00
Thong Kuah
885ea5c33c Make subgroup specs :nested_groups
Subgroups are not supported in mySQL. I changed Namespace#root_ancestor
to return from self_and_ancestors as a bugfix.

```
  184   # Returns all the ancestors of the current namespaces
  185   def ancestors
  186     return self.class.none unless parent_id
  187
  188     Gitlab::GroupHierarchy
  189       .new(self.class.where(id: parent_id))
  190       .base_and_ancestors
  191   end
```

So it seems like on mySQL we accidentally returned the parent group :

```
ancestors = self.class.where(id: parent_id)
ancestors.reorder(nil).find_by(parent_id: nil)
```

Project#root_namespace is used only by shared_runners_limit_namespace
and all the tests for shared_runner_minutes_on_root_namespace are only
enabled on `:nested_groups`

`when :shared_runner_minutes_on_root_namespace is enabled', :nested_groups`

We very clearly state in https://docs.gitlab.com/ee/user/group/subgroups/ that `
Nested groups are only supported when you use PostgreSQL`, so I think I
will fix forward and add `:nested_groups` to the two failing feature
specs.
2018-12-05 10:16:44 +13:00
Mark Chao
a63bce1a4b Resolve "Rename the Master role to Maintainer" Backend 2018-07-11 14:36:08 +00:00
Phil Hughes
82b6f82f71
Fixed web IDE not working for sub-groups
Closes #45412
2018-04-16 17:02:12 +01:00