Commit graph

19 commits

Author SHA1 Message Date
James Edwards-Jones
3185b87c74 Removed unused Service#disabled_title methods 2018-03-15 22:52:24 +00:00
James Lopez
41a14498c7
update code based on feedback 2018-01-26 15:26:27 +01:00
James Lopez
482fc5537f
fix validation error on services 2018-01-26 15:26:25 +01:00
Lin Jen-Shin
5720bce113 Also treat newlines as separator, as people would do that
Before this fix, I don't know if those emails would work
having newlines in them.
2017-09-13 20:24:19 +08:00
Jarka Kadlecova
33d82ccb45 simplify test&save actions when setting a service integration 2017-06-01 07:47:15 +02:00
Rémy Coutable
d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Tiago Botelho
4b6e583ce0 adds test suite 2017-01-22 00:02:29 +00:00
Tiago Botelho
cd51af1a99 adds events to services api deserialization 2017-01-22 00:02:29 +00:00
Lin Jen-Shin
2e067480a9 Rename for a more consistent pipeline worker name, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17039533
2016-10-17 18:12:07 +08:00
Lin Jen-Shin
8dd580f402 It's already async, from Project#execute_services, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_16132555
2016-10-17 07:25:21 +00:00
Lin Jen-Shin
eeeb96c9d0 Change service to be a worker, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_16118195
2016-10-17 07:25:20 +00:00
Lin Jen-Shin
bac500fdeb It no longer needs a block, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_15434727
2016-10-17 07:25:20 +00:00
Lin Jen-Shin
9c2d40649e Remove pusher support because it's covered by notifications 2016-10-17 07:25:20 +00:00
Lin Jen-Shin
f1e5ca3a31 Use any? instead of count > 0, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019#note_16832243
2016-10-13 01:12:00 +08:00
Lin Jen-Shin
9d92d41ff9 Omit else, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019/diffs#note_15336254
2016-09-15 00:00:47 +08:00
Lin Jen-Shin
844d4e24af Use keyword arg, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019/diffs#note_15336212
2016-09-15 00:00:02 +08:00
Lin Jen-Shin
4ad63c29bb Fixed the names and add missing check 2016-09-13 23:38:46 +08:00
Lin Jen-Shin
4add6ca6ec Try to integrate the email into notification system 2016-09-13 19:09:53 +08:00
Lin Jen-Shin
34cbc51e23 Add a new pipeline email service. TODO: email templates and tests 2016-08-26 16:56:55 +08:00