Commit graph

27 commits

Author SHA1 Message Date
Bob Van Landuyt
960559aa68 Don't use canonical path for group children 2017-10-04 22:49:41 +02:00
Bob Van Landuyt
80780018a9 Update children route to handle projects and groups 2017-10-04 22:46:49 +02:00
Bob Van Landuyt
376a8c66c1 Remove the subgroups path on a group 2017-10-04 22:46:49 +02:00
Felipe Artur
b5f596c3ff Native group milestones 2017-07-07 15:08:49 +00:00
Shinya Maeda
f8a2f6f115 Wrap additional routes by dash(-). And remove those routes from path_regex.rb. 2017-07-07 15:35:12 +09:00
Shinya Maeda
5b0954759c Basic BE change
Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Implement CURD

Rename codes related to VariableGroup and VariableProject FE part

Remove unneccesary changes

Make Fe code up-to-date

Add protected flag to migration file

Protected group variables essential package

Update schema

Improve doc

Fix logic and spec for models

Fix logic and spec for controllers

 Fix logic and spec for views(pre feature)

Add feature spec

Fixed bugs. placeholder. reveal button. doc.

Add changelog

Remove unnecessary comment

godfat nice catches

Improve secret_variables_for arctecture

Fix spec

Fix StaticAnlysys & path_regex spec

Revert "Improve secret_variables_for arctecture"

This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.

Use ayufan suggestion for secret_variables_for

Use find instead of find_by

Fix spec message for variable is invalid

Fix spec remove variable.group_id = group.id

godffat spec nitpicks

Use include Gitlab::Routing.url_helpers for presenter spec
2017-07-07 15:33:17 +09:00
Douwe Maan
43b1750892 Revert "Remove changes that are not absolutely necessary"
This reverts commit b0498c176f
2017-05-24 20:59:26 +00:00
Phil Hughes
52d59a4e51 Load milestone tabs asynchronously 2017-04-26 12:23:29 +01:00
Dmitriy Zaporozhets
f39dbf3d3d
Allow creating nested group via UI
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-02-07 15:37:36 +02:00
Dmitriy Zaporozhets
0d9e80c3dd
Fix 500 error for Group#web_url method if nested group
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-01-24 17:44:21 +02:00
Dmitriy Zaporozhets
7e42c22991
Fix 404 error when visit group label edit page
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-12-06 18:50:48 +02:00
Dmitriy Zaporozhets
6683fdcfb0
Add nested groups support to the routing
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-11-23 14:08:36 +02:00
Dmitriy Zaporozhets
beb638ca03
Fix 404 on some group pages when name contains dot
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-11-21 12:41:44 +02:00
Douglas Barbosa Alexandre
198fe1bfc2 Add toggle_subscription action to Groups::LabelsController 2016-11-17 15:10:13 -02:00
Sean McGivern
7be41074bb Merge branch 'dz-refactor-namespace-regex' into 'master'
Refactor namespace regex

Reuse existing namespace regex constant in routing

See merge request !7336
2016-11-08 12:51:51 +00:00
Dmitriy Zaporozhets
7061131676
Refactor namespace regex
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-11-07 18:40:57 +02:00
Dmitriy Zaporozhets
4ca3db3f9d
Refactor group routing
* separate controller actions from nested resources
* prepare group routing for nested namespaces support

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-11-07 15:34:25 +02:00
Dmitriy Zaporozhets
3be445c58e Revert "Revert "Change "Group#web_url" to return "/groups/twitter" rather than "/twitter".""
This reverts commit 9dbd5b3cfa.
2016-10-27 16:16:15 +03:00
Dmitriy Zaporozhets
9dbd5b3cfa Revert "Change "Group#web_url" to return "/groups/twitter" rather than "/twitter"."
This reverts commit c81ff152e0.
2016-10-24 13:14:00 +03:00
Adam Niedzielski
c81ff152e0 Change "Group#web_url" to return "/groups/twitter" rather than "/twitter".
Bring back the old behaviour which was changed by 6b90ccb9.
Fixes #23527.
2016-10-21 13:53:38 +02:00
Douglas Barbosa Alexandre
355389d065 Disable subscribing to group-level labels 2016-10-19 14:58:28 -02:00
Douglas Barbosa Alexandre
52e0c3b565 Add CRUD for Group Labels 2016-10-19 14:57:15 -02:00
Dmitriy Zaporozhets
c48f715318
Fix 404 when group path has dot in the name
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-16 12:49:23 +03:00
Dmitriy Zaporozhets
d7324f0ed5
Move edit group scenario to rspec and refactor groups_spec
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-14 14:51:59 +03:00
Stan Hu
ab2a7a806a Add missing routes to make group edits work
Closes #23306
2016-10-13 23:38:50 -07:00
Dmitriy Zaporozhets
6b90ccb9fd Change user & group landing page routing from /u/:name & /groups/:name to /:name
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-06 19:50:48 +03:00
Dmitriy Zaporozhets
f223a41660
Split routes on multiple files
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-05 15:21:27 +03:00